fix(unzip): replace UserException with ValueError exception in _extract() (aws#8599)

* fix(test): __extract() to use ValueError exception

* move git ignore line

Author: vicheey

.gitignore

@@ -407,6 +407,7 @@ cov.xml
 coverage.xml
 
 # Temporary scratch directory used by the tests
+tests/integration/*/tmp/*
 tests/integration/buildcmd/scratch
 tests/integration/testdata/buildcmd/Dotnet*/bin
 tests/integration/testdata/buildcmd/Dotnet*/obj
@@ -425,4 +426,4 @@ samcli/lib/init/templates/cookiecutter-aws-sam-hello-java-gradle/**/.gradle/
 mise.toml
 
 # Durable executions
-**/.durable-executions-local/
+**/.durable-executions-local/

samcli/local/lambdafn/zip.py

@@ -7,8 +7,6 @@
 import os
 import zipfile
 
-from samcli.commands.exceptions import UserException
-
 LOG = logging.getLogger(__name__)
 
 S_IFLNK = 0xA
@@ -69,7 +67,7 @@ def _extract(file_info, output_dir, zip_ref):
     link_name_abs = os.path.abspath(link_name)
 
     if not link_name_abs.startswith(output_dir_abs + os.sep) and link_name_abs != output_dir_abs:
-        raise UserException(f"Failed to extract file from the zip file. The '{file_info.filename}' is invalid")
+        raise ValueError(f"Failed to extract file from the zip file. The '{file_info.filename}' is invalid")
 
     # make leading dirs if needed
     leading_dirs = os.path.dirname(link_name)