Make bencher CLI Nix job required for releases (#812)

This changeset makes the `bencher` CLI Nix job required for a successful
release.

The Bencher API Nix flake was removed as a part of this change. The
Bencher API Docker image should be used:
https://bencher.dev/download/#api-server

Author: epompeii

.github/workflows/ci.yml

@@ -29,6 +29,7 @@ jobs:
       cli: ${{ steps.filter.outputs.cli }}
       docker: ${{ steps.filter.outputs.docker }}
       runner: ${{ steps.filter.outputs.runner }}
+      nix: ${{ steps.filter.outputs.nix }}
     steps:
       - uses: actions/checkout@v6
       - uses: dorny/paths-filter@v4
@@ -80,6 +81,9 @@ jobs:
               - 'plus/bencher_runner/**'
               - 'services/runner/**'
               - 'tasks/test_runner/**'
+            nix:
+              - 'flake.nix'
+              - 'flake.lock'
 
   lint:
     name: Lint
@@ -152,6 +156,15 @@ jobs:
       mold-version: "2.34.1"
       litestream-version: "0.5.10"
 
+  nix:
+    name: Nix
+    needs: changes
+    if: github.ref != 'refs/heads/cloud'
+    uses: ./.github/workflows/nix.yml
+    with:
+      nix-lint: ${{ needs.changes.outputs.nix == 'true' }}
+      nix-build: ${{ needs.changes.outputs.nix == 'true' || needs.changes.outputs.cli == 'true' }}
+
   deploy:
     name: Deploy
     needs: [lint, cli, test, build]
@@ -174,7 +187,7 @@ jobs:
   release:
     name: Release
     if: ${{ !failure() && !cancelled() && github.ref != 'refs/heads/cloud' && (needs.changes.outputs.rust == 'true' || github.ref == 'refs/heads/devel' || startsWith(github.ref, 'refs/tags/')) }}
-    needs: [changes, lint, cli, runner, test, build, docker]
+    needs: [changes, lint, cli, runner, test, build, docker, nix]
     uses: ./.github/workflows/release.yml
     with:
       mold-version: "2.34.1"

.github/workflows/nix.yml

@@ -1,87 +1,19 @@
 name: Nix
 
 on:
-  workflow_dispatch:
-  push:
-    branches: [devel, cloud]
-    tags: [v**]
-  pull_request:
-    branches: [main, cloud, devel]
-
-# Cancel in-progress runs for the same branch
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true
+  workflow_call:
+    inputs:
+      nix-lint:
+        type: boolean
+        required: true
+      nix-build:
+        type: boolean
+        required: true
 
 jobs:
-  changes:
-    name: Detect Changes
-    if: github.ref != 'refs/heads/cloud'
-    runs-on: ubuntu-22.04
-    outputs:
-      nix: ${{ steps.filter.outputs.nix }}
-      cli: ${{ steps.filter.outputs.cli }}
-      api: ${{ steps.filter.outputs.api }}
-    steps:
-      - uses: actions/checkout@v6
-      - uses: dorny/paths-filter@v4
-        id: filter
-        with:
-          filters: |
-            nix:
-              - 'flake.nix'
-              - 'flake.lock'
-              - '.github/workflows/nix.yml'
-            cli:
-              - 'services/cli/**'
-              - 'lib/bencher_adapter/**'
-              - 'lib/bencher_client/**'
-              - 'lib/bencher_comment/**'
-              - 'lib/bencher_context/**'
-              - 'lib/bencher_json/**'
-              - 'lib/bencher_noise/**'
-              - 'lib/bencher_parser/**'
-              - 'lib/bencher_valid/**'
-            api:
-              - 'services/api/**'
-              - 'lib/api_auth/**'
-              - 'lib/api_checkout/**'
-              - 'lib/api_organizations/**'
-              - 'lib/api_projects/**'
-              - 'lib/api_run/**'
-              - 'lib/api_server/**'
-              - 'lib/api_users/**'
-              - 'lib/bencher_adapter/**'
-              - 'lib/bencher_boundary/**'
-              - 'lib/bencher_config/**'
-              - 'lib/bencher_context/**'
-              - 'lib/bencher_endpoint/**'
-              - 'lib/bencher_json/**'
-              - 'lib/bencher_logger/**'
-              - 'lib/bencher_plot/**'
-              - 'lib/bencher_rank/**'
-              - 'lib/bencher_rbac/**'
-              - 'lib/bencher_schema/**'
-              - 'lib/bencher_token/**'
-              - 'lib/bencher_valid/**'
-              - 'plus/api_oci/**'
-              - 'plus/api_runners/**'
-              - 'plus/api_specs/**'
-              - 'plus/bencher_billing/**'
-              - 'plus/bencher_bing_index/**'
-              - 'plus/bencher_github_client/**'
-              - 'plus/bencher_google_client/**'
-              - 'plus/bencher_google_index/**'
-              - 'plus/bencher_license/**'
-              - 'plus/bencher_oci_storage/**'
-              - 'plus/bencher_otel/**'
-              - 'plus/bencher_otel_provider/**'
-              - 'plus/bencher_recaptcha/**'
-
   nix_lints:
-    name: Check nix code
-    needs: changes
-    if: ${{ needs.changes.outputs.nix == 'true' }}
+    name: Check Nix code
+    if: ${{ inputs.nix-lint }}
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v6
@@ -98,8 +30,7 @@ jobs:
 
   build_bencher_nix:
     name: Build `bencher` Nix Package
-    needs: changes
-    if: ${{ needs.changes.outputs.nix == 'true' || needs.changes.outputs.cli == 'true' }}
+    if: ${{ inputs.nix-build }}
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v6
@@ -109,17 +40,3 @@ jobs:
           nix_path: nixpkgs=channel:nixos-25.11
       - name: Nix build
         run: nix build .#bencher
-
-  build_api_nix:
-    name: Build `api` Nix Package
-    needs: changes
-    if: ${{ needs.changes.outputs.nix == 'true' || needs.changes.outputs.api == 'true' }}
-    runs-on: ubuntu-22.04
-    steps:
-      - uses: actions/checkout@v6
-      - name: Install Nix
-        uses: cachix/install-nix-action@v25
-        with:
-          nix_path: nixpkgs=channel:nixos-25.11
-      - name: Nix build
-        run: nix build .#api

CLAUDE.md

@@ -178,4 +178,4 @@ When adding a new crate, update all four `Dockerfile`s:
 
 ## CI Path Filters
 
-When adding a new crate or changing crate dependencies, update the path filters in `.github/workflows/ci.yml` and `.github/workflows/nix.yml` (`changes` jobs) for any affected filter (`rust`, `api`, `cli`, `runner`, `console`, `action`, `docker`).
+When adding a new crate or changing crate dependencies, update the path filters in `.github/workflows/ci.yml` (`changes` job) for any affected filter (`rust`, `cli`, `runner`, `console`, `action`, `docker`, `nix`).

flake.nix

@@ -62,7 +62,6 @@
         packages = rec {
           default = bencher;
           bencher = mkPackage "bencher";
-          api = mkPackage "api";
         };
         # Enter reproducible development shell with `nix develop`
         devShells = {
@@ -82,10 +81,6 @@
           bencher = flake-utils.lib.mkApp {
             drv = self.packages.${system}.bencher;
           };
-          # nix run .#api
-          api = flake-utils.lib.mkApp {
-            drv = self.packages.${system}.api;
-          };
         };
       }
     );