Merge pull request #53 from bflad/rubocop_fixes

Rubocop fixes and ignores

Author: bflad

files/default/tests/minitest/apache2_test.rb

@@ -14,5 +14,4 @@
   it 'enables apache' do
     apache_service.must_be_enabled
   end
-
 end

files/default/tests/minitest/configuration_test.rb

@@ -6,5 +6,4 @@
   it 'creates Stash properties file' do
     file("#{node['stash']['home_path']}/shared/stash-config.properties").must_exist
   end
-
 end

files/default/tests/minitest/default_test.rb

@@ -2,5 +2,4 @@
 
 describe_recipe 'stash::default' do
   include Helpers::Stash
-
 end

files/default/tests/minitest/linux_standalone_test.rb

@@ -10,5 +10,4 @@
   it 'creates Java KeyStore' do
     file("#{node['stash']['home_path']}/.keystore").must_exist.with(:owner, node['stash']['user'])
   end
-
 end

files/default/tests/minitest/service_init_test.rb

@@ -10,5 +10,4 @@
   it 'enables Stash' do
     service('stash').must_be_enabled
   end
-
 end

libraries/stash.rb

@@ -4,6 +4,7 @@ class Chef
   class Recipe
     # Chef::Recipe::Stash class
     class Stash
+      # rubocop:disable Metrics/AbcSize
       def self.settings(node)
         begin
           if Chef::Config[:solo]
@@ -27,6 +28,7 @@ def self.settings(node)
 
         settings
       end
+      # rubocop:enable Metrics/AbcSize
 
       def self.default_database_port(type)
         case type

providers/hook.rb

@@ -56,6 +56,7 @@ def whyrun_supported?
   end
 end
 
+# rubocop:disable Metrics/AbcSize
 def load_current_resource
   server = @new_resource.server
   user = @new_resource.user
@@ -74,6 +75,7 @@ def load_current_resource
 
   @current_resource.settings hook_settings(server, hook_opts) if @current_resource.configured
 end
+# rubocop:enable Metrics/AbcSize
 
 private
 

recipes/apache2.rb

@@ -7,7 +7,7 @@
 include_recipe 'apache2::mod_ssl'
 
 # Disable mod_auth_basic because it isn't supported in Stash 2.10 and later
-apache_module "auth_basic" do
+apache_module 'auth_basic' do
   enable false
 end