fix: test and fix compatibility with min flutter version (#1510)

Gustl22 · web-flow · commit 9f39e95ff791 · 2023-05-24T13:55:30.000+02:00
# Description

- Compatibility with min flutter version
- Allow configure Flutter version in dispatch workflow
- Run tests with min required flutter version on release
diff --git a/.github/workflows/build-example.yml b/.github/workflows/build-example.yml
@@ -2,6 +2,17 @@ name: build example
 on:
   workflow_dispatch:
     inputs:
+      flutter_version:
+        description: 'Flutter Version'
+        required: false
+        default: '3.7.x'
+        type: choice
+        options:
+          - 'any'
+          - '3.10.x'
+          - '3.7.x'
+          - '3.3.x'
+          - '3.0.x'
       enable_android:
         description: 'Build Android'
         required: false
@@ -34,6 +45,10 @@ on:
         type: boolean
   workflow_call:
     inputs:
+      flutter_version:
+        required: false
+        default: '3.7.12'
+        type: string
       enable_android:
         required: false
         default: true
@@ -68,7 +83,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
 
@@ -84,7 +99,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
 
@@ -100,7 +115,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
 
@@ -116,7 +131,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
 
@@ -136,7 +151,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
 
@@ -152,7 +167,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
 
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -0,0 +1,14 @@
+name: release
+on:
+  push:
+    tags:
+      - '*'
+
+jobs:
+  call-min-flutter-test:
+    uses: ./.github/workflows/test.yml
+    with:
+      flutter_version: '3.3.x'
+      fatal_warnings: false
+      # TODO(gustl22): Windows tests fail on Flutter <= 3.3.x, remove when setting min version to 3.7.x
+      enable_windows: false
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -2,6 +2,22 @@ name: test
 on:
   workflow_dispatch:
     inputs:
+      flutter_version:
+        description: 'Flutter Version'
+        required: false
+        default: '3.7.x'
+        type: choice
+        options:
+          - 'any'
+          - '3.10.x'
+          - '3.7.x'
+          - '3.3.x'
+          - '3.0.x'
+      fatal_warnings:
+        description: 'Treat warnings as fatal'
+        required: false
+        default: true
+        type: boolean
       enable_android:
         description: 'Test Android'
         required: false
@@ -34,6 +50,14 @@ on:
         type: boolean
   workflow_call:
     inputs:
+      flutter_version:
+        required: false
+        default: '3.7.12'
+        type: string
+      fatal_warnings:
+        required: false
+        default: true
+        type: boolean
       enable_android:
         required: false
         default: true
@@ -68,12 +92,12 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
 
       - run: melos run format-check
-      - run: melos run analyze
+      - run: melos run analyze -- ${{ inputs.fatal_warnings && '--fatal-infos' || '--no-fatal-warnings --no-fatal-infos' }}
       - run: melos run test
 
   web:
@@ -84,7 +108,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
       - uses: nanasess/setup-chromedriver@v1
@@ -122,7 +146,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
 
@@ -162,7 +186,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
 
@@ -190,7 +214,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
 
@@ -215,7 +239,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
       
@@ -245,7 +269,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: ${{ inputs.flutter_version }}
           channel: 'stable'
       - uses: bluefireteam/melos-action@main
       - name: Install Flutter requirements for Linux
diff --git a/melos.yaml b/melos.yaml
@@ -21,7 +21,7 @@ scripts:
     description: Run all static analysis checks.
 
   analyze:
-    run: melos exec -c 10 flutter analyze --fatal-infos
+    run: melos exec -c 10 flutter analyze
     description: Run `flutter analyze` for all packages.
 
   format:
diff --git a/packages/audioplayers/example/android/app/build.gradle b/packages/audioplayers/example/android/app/build.gradle
@@ -26,8 +26,7 @@ apply plugin: 'kotlin-android'
 apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
 
 android {
-    compileSdk flutter.compileSdkVersion
-    ndkVersion flutter.ndkVersion
+    compileSdk 33
 
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_11
diff --git a/packages/audioplayers/example/pubspec.yaml b/packages/audioplayers/example/pubspec.yaml
@@ -29,5 +29,5 @@ flutter:
     - assets/
 
 environment:
-  sdk: ">=2.17.0 <3.0.0"
-  flutter: ">=3.0.0"
+  sdk: ">=2.18.0 <3.0.0"
+  flutter: ">=3.3.0"
diff --git a/packages/audioplayers/example/server/pubspec.yaml b/packages/audioplayers/example/server/pubspec.yaml
@@ -2,7 +2,7 @@ name: audioplayers_test_server
 publish_to: none
 
 environment:
-  sdk: ">=2.17.0 <3.0.0"
+  sdk: ">=2.18.0 <3.0.0"
 
 dependencies:
   shelf: ^1.2.0
diff --git a/packages/audioplayers/lib/src/audio_cache.dart b/packages/audioplayers/lib/src/audio_cache.dart
@@ -1,9 +1,5 @@
 import 'dart:async';
 
-// TODO(gustl22): remove when upgrading min Flutter version to >=3.3.0
-// ignore: unnecessary_import
-import 'dart:typed_data';
-
 import 'package:file/file.dart';
 import 'package:file/local.dart';
 import 'package:flutter/foundation.dart';
diff --git a/packages/audioplayers/lib/src/audioplayer.dart b/packages/audioplayers/lib/src/audioplayer.dart
@@ -1,7 +1,4 @@
 import 'dart:async';
-// TODO(gustl22): remove when upgrading min Flutter version to >=3.3.0
-// ignore: unnecessary_import
-import 'dart:typed_data';
 
 import 'package:audioplayers/audioplayers.dart';
 import 'package:audioplayers_platform_interface/audioplayers_platform_interface.dart';
diff --git a/packages/audioplayers/pubspec.yaml b/packages/audioplayers/pubspec.yaml
@@ -31,9 +31,9 @@ dependencies:
   flutter:
     sdk: flutter
   http: ^0.13.5
-  meta: ^1.8.0
+  meta: ^1.7.0
   path_provider: ^2.0.12
-  synchronized: ^3.0.1
+  synchronized: ^3.0.0
   uuid: ^3.0.7
 
 dev_dependencies:
@@ -43,6 +43,6 @@ dev_dependencies:
     sdk: flutter
 
 environment:
-  sdk: ">=2.17.0 <3.0.0"
-  flutter: ">=3.0.0"
+  sdk: ">=2.18.0 <3.0.0"
+  flutter: ">=3.3.0"
 
diff --git a/packages/audioplayers_android/pubspec.yaml b/packages/audioplayers_android/pubspec.yaml
@@ -24,6 +24,6 @@ dev_dependencies:
     sdk: flutter
 
 environment:
-  sdk: ">=2.17.0 <3.0.0"
-  flutter: ">=3.0.0"
+  sdk: ">=2.18.0 <3.0.0"
+  flutter: ">=3.3.0"
 
diff --git a/packages/audioplayers_darwin/pubspec.yaml b/packages/audioplayers_darwin/pubspec.yaml
@@ -25,6 +25,6 @@ dev_dependencies:
     sdk: flutter
 
 environment:
-  sdk: ">=2.17.0 <3.0.0"
-  flutter: ">=3.0.0"
+  sdk: ">=2.18.0 <3.0.0"
+  flutter: ">=3.3.0"
 
diff --git a/packages/audioplayers_linux/pubspec.yaml b/packages/audioplayers_linux/pubspec.yaml
@@ -23,6 +23,6 @@ dev_dependencies:
     sdk: flutter
 
 environment:
-  sdk: ">=2.17.0 <3.0.0"
-  flutter: ">=3.0.0"
+  sdk: ">=2.18.0 <3.0.0"
+  flutter: ">=3.3.0"
 
diff --git a/packages/audioplayers_platform_interface/lib/src/audioplayers_platform.dart b/packages/audioplayers_platform_interface/lib/src/audioplayers_platform.dart
@@ -1,7 +1,4 @@
 import 'dart:async';
-// TODO(gustl22): remove when upgrading min Flutter version to >=3.3.0
-// ignore: unnecessary_import
-import 'dart:typed_data';
 
 import 'package:audioplayers_platform_interface/src/api/audio_context.dart';
 import 'package:audioplayers_platform_interface/src/api/audio_event.dart';
diff --git a/packages/audioplayers_platform_interface/pubspec.yaml b/packages/audioplayers_platform_interface/pubspec.yaml
@@ -7,7 +7,7 @@ repository: https://github.com/bluefireteam/audioplayers/tree/master/packages/au
 dependencies:
   flutter:
     sdk: flutter
-  meta: ^1.8.0
+  meta: ^1.7.0
   plugin_platform_interface: ^2.0.2
 
 dev_dependencies:
@@ -17,5 +17,5 @@ dev_dependencies:
     sdk: flutter
 
 environment:
-  sdk: ">=2.17.0 <3.0.0"
-  flutter: ">=3.0.0"
+  sdk: ">=2.18.0 <3.0.0"
+  flutter: ">=3.3.0"
diff --git a/packages/audioplayers_web/pubspec.yaml b/packages/audioplayers_web/pubspec.yaml
@@ -26,5 +26,5 @@ dev_dependencies:
     sdk: flutter
 
 environment:
-  sdk: ">=2.17.0 <3.0.0"
-  flutter: ">=3.0.0"
+  sdk: ">=2.18.0 <3.0.0"
+  flutter: ">=3.3.0"
diff --git a/packages/audioplayers_windows/pubspec.yaml b/packages/audioplayers_windows/pubspec.yaml
@@ -23,6 +23,6 @@ dev_dependencies:
     sdk: flutter
 
 environment:
-  sdk: ">=2.17.0 <3.0.0"
-  flutter: ">=3.0.0"
+  sdk: ">=2.18.0 <3.0.0"
+  flutter: ">=3.3.0"
 
