fix!: Cache should take key to be properly cleared#1347
Merged
Conversation
spydon
requested review from
Gustl22,
erickzanardo,
luanpotter,
renancaraujo and
wolfenrain
wolfenrain
approved these changes
Dec 18, 2022
Gustl22
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The cache was not being cleared properly since it wasn't the correct type for the key passed in to
clearand it was mappingvaluesinstead ofkeysinclearAll.Checklist
fix:,feat:,docs:,chore:etc).///, where necessary.Breaking Change
Migration instructions
Pass in the name of the path as a string to
clearinstead of aUri.Related Issues
Closes #1346