You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There has been a high number of issues being opened around the fact that on 1.0.0, forceSpeaker on iOS (and android) was set to false by default, requiring most users to explicitly setup the global audio context.
This change the default value of iOS audio context to force speakers to be inline with what users seem to expect.
Do we have any possibility to test this on a real device @luanpotter?
We may could ask in the thread, to test this branch(?).
I for myself managed to get it running on a real ipad compliling via MacOS VM. But that doesn't have an Earpeace, so there's no difference noticable in changing the settings.
Or we just try out the change and see if anyone complains after the release?
I'm fine with the change though, better than doing nothing about it ;)
Do we have any possibility to test this on a real device @luanpotter?
He doesn't.
We may could ask in the thread, to test this branch(?). I for myself managed to get it running on a real ipad compliling via MacOS VM. But that doesn't have an Earpeace, so there's no difference noticable in changing the settings. Or we just try out the change and see if anyone complains after the release?
I'll do a release and tell people in the thread to try, we can just roll it back and do a new release if some iPhone's explode. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There has been a high number of issues being opened around the fact that on 1.0.0,
forceSpeakeron iOS (and android) was set tofalseby default, requiring most users to explicitly setup the global audio context.This change the default value of iOS audio context to force speakers to be inline with what users seem to expect.
Follow this thread for details.
Since I only test iOS on emulators, where this setting doesn't make any difference, I hadn't realized this issue.
Note: this changes the default for android as well, which is in line with the unified audio context philosophy.
Checklist
fix:,feat:,docs:,chore:etc).///, where necessary.Breaking Change
Migration instructions
If you wanted to have it set to false, you can just set it so:
If not, you can remove all the ad-hoc code you had to set this up.
Related Issues