Skip to content

refactor!: rename logger_platform_interface to global_platform_interface#1385

Merged
Gustl22 merged 1 commit into
mainfrom
gustl22/refactor-platform-interface
Jan 16, 2023
Merged

refactor!: rename logger_platform_interface to global_platform_interface#1385
Gustl22 merged 1 commit into
mainfrom
gustl22/refactor-platform-interface

Conversation

@Gustl22

@Gustl22 Gustl22 commented Jan 15, 2023

Copy link
Copy Markdown
Collaborator

Description

It would be more appropriate to name the logger_platform_interface after it's general content, which is the global platform interface.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Migration instructions

Before:

import 'package:audioplayers_platform_interface/logger_platform_interface.dart';

After:

import 'package:audioplayers_platform_interface/global_platform_interface.dart';

Related Issues

@Gustl22 Gustl22 requested review from luanpotter and spydon January 15, 2023 21:15

@spydon spydon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, pretty sure nobody will be affected by this breaking change.

@Gustl22 Gustl22 merged commit 6e837c1 into main Jan 16, 2023
@Gustl22 Gustl22 deleted the gustl22/refactor-platform-interface branch January 16, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants