refactor!: rename logger_platform_interface to global_platform_interface#1385
Merged
Conversation
spydon
approved these changes
Jan 15, 2023
spydon
left a comment
Member
There was a problem hiding this comment.
Lgtm, pretty sure nobody will be affected by this breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It would be more appropriate to name the logger_platform_interface after it's general content, which is the global platform interface.
Checklist
fix:,feat:,docs:,chore:etc).///, where necessary.Breaking Change
Migration instructions
Before:
After:
Related Issues