Skip to content

feat: example improvements#1392

Merged
Gustl22 merged 16 commits into
mainfrom
gustl22/example-layout
Jan 20, 2023
Merged

feat: example improvements#1392
Gustl22 merged 16 commits into
mainfrom
gustl22/example-layout

Conversation

@Gustl22

@Gustl22 Gustl22 commented Jan 19, 2023

Copy link
Copy Markdown
Collaborator

Description

  • add ability to change Android and iOS specific contexts
  • Permission for WAKE_LOCK and MODIFY_AUDIO_SETTINGS
  • improved layout of widgets (more spacing, responsive height, etc.)
  • preserve state for each player
  • style toggles
  • add some icons

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@Gustl22 Gustl22 marked this pull request as ready for review January 19, 2023 15:54
@Gustl22 Gustl22 requested review from luanpotter and spydon January 19, 2023 15:54
@Gustl22

Gustl22 commented Jan 20, 2023

Copy link
Copy Markdown
Collaborator Author

@spydon I now found a way to omit PlayerUiState which is much more elegant. And did some more small changes. Only noting, if you want to review again...

@spydon

spydon commented Jan 20, 2023

Copy link
Copy Markdown
Member

Not sure why the checks are failing (haven't checked, I'm in the alps 😅)

@Gustl22 Gustl22 merged commit 002e2fc into main Jan 20, 2023
@Gustl22 Gustl22 deleted the gustl22/example-layout branch January 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants