Skip to content

feat(ios): set player context globally on setAudioContext for iOS only#1416

Merged
Gustl22 merged 6 commits into
mainfrom
gustl22/1396-ios-player-context
Feb 10, 2023
Merged

feat(ios): set player context globally on setAudioContext for iOS only#1416
Gustl22 merged 6 commits into
mainfrom
gustl22/1396-ios-player-context

Conversation

@Gustl22

@Gustl22 Gustl22 commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator

Description

  • Update ios generated files
  • more intuitive handling of ios player context for setAudioContext

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change. Kind of, but I think no-one cares.
  • No, this is not a breaking change.

Related Issues

Closes #1396

@Gustl22 Gustl22 changed the title feat(ios): set player context globally on setAudioContext for iOS feat(ios): set player context globally on setAudioContext for iOS only Feb 8, 2023
@Gustl22 Gustl22 marked this pull request as ready for review February 8, 2023 18:34
@Gustl22 Gustl22 requested review from luanpotter and spydon February 8, 2023 18:34
@Gustl22

Gustl22 commented Feb 9, 2023

Copy link
Copy Markdown
Collaborator Author

@luanpotter do you have any concerns with that change?

@luanpotter luanpotter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@Gustl22 Gustl22 merged commit 19af364 into main Feb 10, 2023
@Gustl22 Gustl22 deleted the gustl22/1396-ios-player-context branch February 10, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] better handling of setting AudioContext for single player instance

3 participants