fix: onPrepared event to wait until player is ready / finished loading the source#1469
Merged
Conversation
Gustl22
commented
Apr 11, 2023
Gustl22
force-pushed
the
gustl22/prepare-event
branch
from
9f6c36a to
46c4153
Compare
7 tasks
This reverts commit 9cda452.
# Conflicts: # .github/workflows/test.yml # packages/audioplayers/example/integration_test/lib_test.dart # packages/audioplayers/lib/src/audioplayer.dart # packages/audioplayers_android/android/src/main/kotlin/xyz/luan/audioplayers/AudioplayersPlugin.kt # packages/audioplayers_linux/linux/audio_player.cc # packages/audioplayers_linux/linux/audioplayers_linux_plugin.cc
# Conflicts: # packages/audioplayers/example/integration_test/lib_test.dart # packages/audioplayers_linux/linux/audio_player.cc
spydon
approved these changes
May 4, 2023
This reverts commit f2cb634.
# Conflicts: # packages/audioplayers/example/integration_test/tabs/stream_tab.dart
Collaborator
Author
|
@spydon do you agree merging it like that. I expect flutter/flutter#126209 to take some time... 😅 |
2 tasks
Member
Sure, since we're tracking it on our side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a callback when the player has prepared its source, which is tangled to the asynchronous
setSourcemethod, to improve experience, when player should actually play and not wait for the player to prepare / load the source.Checklist
fix:,feat:,docs:,chore:etc).///, where necessary.Breaking Change
Related Issues
Closes #1118
Closes #1384
Closes #1359
#1191