fix(android): onPlayerStateChanged is not called when audio has completed playing#1523
Merged
Conversation
Collaborator
|
Nice catch! Do you think But I'm a bit confused about the comment below this, but it should't make a big difference, as the runnable (and it's loop) will end after one update circle. We may should test this once anyway :) |
onPlayerStateChanged is not called when audio has completed playingonPlayerStateChanged is not called when audio has completed playing
onPlayerStateChanged is not called when audio has completed playingonPlayerStateChanged is not called when audio has completed playing
Contributor
Author
I am not sure. If it only removes that one specific runnable then maybe yes? |
Contributor
Author
|
Btw this is partially why I do hope to implement #1527 - then there is no such callbacks, runnables, threads, etc! |
Gustl22
approved these changes
May 29, 2023
Collaborator
|
@fzyzcjy Is it ok for you to merge it like this (after my changes)? |
Contributor
Author
|
LGTM! (not tested yet though) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #1522
I am not sure whether this is the best way, but I can confirm it fixes the bug I see, and IMHO there are not infinitely many handler callbacks, so skipping this cancelation does not cause harm.
Checklist
fix:,feat:,docs:,chore:etc).///, where necessary.Breaking Change
Related Issues