refactor!: Remove deprecated methods#1583
Merged
Merged
Conversation
Collaborator
Author
|
@spydon any opinion on this? Thank you for reviewing ;D |
Member
Hmm, since we don't really have a strategy for this library yet I think you can choose whichever you think fits the best. :) |
Gustl22
changed the title
spydon
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I missed to remove the deprecated methods in #1453.
We can either:
5.1.0for a release, as the migration instructions for the introduced breaking changes were already explained in the previous PRs.6.0.0instantlyI'd propose the first or the last option.
Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
Migration instructions
See #1352 and #1443
Related Issues
Closes #1453