Skip to content

feat(windows): Support for BytesSource on Windows#1601

Merged
Gustl22 merged 8 commits into
bluefireteam:mainfrom
dogukangulyasar:main
Sep 23, 2023
Merged

feat(windows): Support for BytesSource on Windows#1601
Gustl22 merged 8 commits into
bluefireteam:mainfrom
dogukangulyasar:main

Conversation

@dogukangulyasar

@dogukangulyasar dogukangulyasar commented Aug 12, 2023 •
edited by Gustl22
Loading

Copy link
Copy Markdown
Contributor

Description

This PR will support "setSourceBytes" method for Windows OS.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example. // There is no specific usage for it, just like "setSourceUrl".

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#1269
Closes #1600
Closes #1467

@dogukangulyasar

dogukangulyasar commented Aug 12, 2023

Copy link
Copy Markdown
Contributor Author

@spydon for your interest.

@spydon spydon requested a review from Gustl22 August 12, 2023 14:01
Gustl22
Gustl22 reviewed Aug 14, 2023
View reviewed changes

@Gustl22 Gustl22 left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of that. I added some comments :D

You may also want to adapt the feature parity table for windows to support byte array.

Comment thread packages/audioplayers_windows/windows/audio_player.cpp Outdated
Comment thread packages/audioplayers_windows/windows/audio_player.cpp Outdated
@Gustl22
Merge branch 'main' into dogukangulyasar/bytesource-windows
bf46552 
# Conflicts:
#	packages/audioplayers_windows/windows/audio_player.h
#	packages/audioplayers_windows/windows/audioplayers_windows_plugin.cpp
@Gustl22
feat(windows): Support BytesSource for Windows
423d533
@Gustl22
Enable bytesSource tests for Windows
68014b0
@Gustl22 Gustl22 changed the title feat: Windows ByteSource support added feat(windows): Support for BytesSource on Windows Sep 23, 2023
@Gustl22 Gustl22 merged commit a9e1471 into bluefireteam:main Sep 23, 2023
Gustl22 added a commit that referenced this pull request Sep 26, 2023
@dogukangulyasar @Gustl22
feat(windows): Support for BytesSource on Windows (#1601)
0c63c29 
# Description

This PR will support "setSourceBytes" method for Windows OS.

## Related Issues
#1269
Closes #1600
Closes #1467

---------

Co-authored-by: Gustl22 <git@reb0.org>
(cherry picked from commit a9e1471)
Gustl22 added a commit that referenced this pull request Nov 14, 2023
@dogukangulyasar @Gustl22
feat(windows): Support for BytesSource on Windows (#1601)
b2bc3d9 
# Description

This PR will support "setSourceBytes" method for Windows OS.

## Related Issues
#1269 
Closes #1600
Closes #1467

---------

Co-authored-by: Gustl22 <git@reb0.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gustl22 Gustl22 Gustl22 left review comments

@spydon spydon spydon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@dogukangulyasar @spydon @Gustl22
⚡