fix: Cancel onPreparedSubscription on error#1660
Merged
Merged
Conversation
Closed
2 tasks
spydon
approved these changes
Oct 2, 2023
Gustl22
added a commit
that referenced
this pull request
Nov 14, 2023
# Description If an error occurred during setting the source, the `onPreparedSubscription` was still listened to, although it is not needed anymore. This triggered a `Future already completed` error. ## Related Issues Fixes #1642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If an error occurred during setting the source, the
onPreparedSubscriptionwas still listened to, although it is not needed anymore. This triggered aFuture already completederror.Related Issues
Fixes #1642