fix: Propagate Stream Errors through the same Future#1732
Conversation
|
@spydon we may can merge this even with the error (?). The problem seems to be solved with the linux workaround in #1715, but this requires pumping Flutter which is also happening there, and requires more changes. This "fix" should be logically independent from bumping, though. It's a chicken-egg-problem. |
Let's just merge both? So that it still works for people depending on main |
|
Yes, the lib works, even with the change, only the linux test fails, due to a the "pump" bug. But I would prefer to have two separate commits in the main branch, to have them separated in the log / changelog. After that, we can merge #1715 |
|
Thanks, unfortunately I cannot force merge with unresolved checks, maybe you have the permission to do so... |
|
Nice 🥳 |
Description
Wait simultaneously for async calls (Futures and Streams) to ensure all errors are propagated through one common future. Previously a stream could throw an error before it was even listened to, as the process still awaited an async call (here
setSource).Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.The tests are adapted, but not explicitly written to avoid that error. But the error would occur since Flutter 3.16.x, so they are tested against in #1715 without further ado.
Breaking Change
Related Issues
#1715