Skip to content

feat: Dispose players on Hot restart (closes #1120)#1905

Merged
Gustl22 merged 1 commit into
mainfrom
gustl22/1120-hot-reload
Mar 10, 2025
Merged

feat: Dispose players on Hot restart (closes #1120)#1905
Gustl22 merged 1 commit into
mainfrom
gustl22/1120-hot-reload

Conversation

@Gustl22

@Gustl22 Gustl22 commented Mar 8, 2025

Copy link
Copy Markdown
Collaborator

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Closes #1120

@Gustl22 Gustl22 force-pushed the gustl22/1120-hot-reload branch from 4d021bd to 8d7c743 Compare March 10, 2025 22:50
@Gustl22 Gustl22 requested a review from spydon March 10, 2025 22:51

@spydon spydon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Gustl22 Gustl22 enabled auto-merge (squash) March 10, 2025 23:05
@Gustl22 Gustl22 merged commit 92bcb19 into main Mar 10, 2025
@Gustl22 Gustl22 deleted the gustl22/1120-hot-reload branch March 10, 2025 23:09
makotosato-at added a commit to makotosato-at/flutter-elinux-plugins that referenced this pull request Feb 9, 2026
see also: bluefireteam/audioplayers#1905

Signed-off-by: Makoto Sato <makoto.sato@atmark-techno.com>
martinetd pushed a commit to makotosato-at/flutter-elinux-plugins that referenced this pull request Feb 18, 2026
see also: bluefireteam/audioplayers#1905

Signed-off-by: Makoto Sato <makoto.sato@atmark-techno.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hot restarts continues playing old players

2 participants