Skip to content

feat: Customizable preparation and seeking timeout#1921

Merged
Gustl22 merged 3 commits into
bluefireteam:mainfrom
kubito:feat/1920-timeout
Jun 15, 2025
Merged

feat: Customizable preparation and seeking timeout#1921
Gustl22 merged 3 commits into
bluefireteam:mainfrom
kubito:feat/1920-timeout

Conversation

@kubito

@kubito kubito commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

Description

Added customizable timeout used for seeking and preparation of the player.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in [example].

Breaking Change

If the PR is a breaking change this should be indicated with suffix "!"
(for example, feat!:, fix!:). See [Conventional Commit] for details. -->

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Closes #1920

@Gustl22

Gustl22 commented Jun 5, 2025

Copy link
Copy Markdown
Collaborator

Thank you for the contribution and sorry for the big delay.

I think a more general approach would be to have a static variable AudioPlayer.preparationTimeout and AudioPlayer.seekingTimeout, which can be set beforehand (not per player). Would that be feasable?

@kubito

kubito commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

@Gustl22 Done, thank you for your suggestions!

Comment thread packages/audioplayers/lib/src/audioplayer.dart Outdated
Co-authored-by: August <git@reb0.org>
@kubito kubito requested a review from Gustl22 June 13, 2025 11:53

@Gustl22 Gustl22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks. Let me know if it works out for you.

@Gustl22 Gustl22 changed the title feat: Customizable timeout feat: Customizable preparation and seeking timeout Jun 15, 2025
@Gustl22 Gustl22 merged commit d5a63f8 into bluefireteam:main Jun 15, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set custom Timeout for initializing the player

2 participants