Simplify the knife runners by using a mixin

Author: gregkare

lib/chef/knife/cookbook_inspect.rb

@@ -1,36 +1,13 @@
 require 'chef/knife'
+require 'health_inspector'
 
 class Chef
   class Knife
     class CookbookInspect < Knife
+      include HealthInspector::Runner
 
-      deps do
-        require 'health_inspector'
-        require 'chef/json_compat'
-        require 'uri'
-        require 'chef/cookbook_version'
-      end
-
-      banner "knife cookbook inspect [COOKBOOK] (options)"
-
-      def run
-        case @name_args.length
-        when 1 # We are inspecting a cookbook
-          cookbook_name = @name_args[0]
-          # TODO: Support environments
-          # env           = config[:environment]
-          # api_endpoint  = env ? "environments/#{env}/cookbooks/#{cookbook_name}" : "cookbooks/#{cookbook_name}"
-
-          validator = HealthInspector::Checklists::Cookbooks.new(self)
-          exit validator.validate_item( validator.load_item(cookbook_name) )
-        when 0 # We are inspecting all the cookbooks
-          exit HealthInspector::Checklists::Cookbooks.run(self)
-        end
-      end
+      checklist HealthInspector::Checklists::Cookbooks
+      banner    "knife cookbook inspect [COOKBOOK] (options)"
     end
   end
 end
-
-
-
-

lib/chef/knife/environment_inspect.rb

@@ -1,25 +1,13 @@
 require 'chef/knife'
+require 'health_inspector'
 
 class Chef
   class Knife
     class EnvironmentInspect < Knife
+      include HealthInspector::Runner
 
-      deps do
-        require 'health_inspector'
-      end
-
-      banner "knife environment inspect [ENVIRONMENT] (options)"
-
-      def run
-        case @name_args.length
-        when 1 # We are inspecting a environment
-          environment_name = @name_args[0]
-          validator = HealthInspector::Checklists::Environments.new(self)
-          exit validator.validate_item( validator.load_item(environment_name) )
-        when 0 # We are inspecting all the environments
-          exit HealthInspector::Checklists::Environments.run(self)
-        end
-      end
+      checklist HealthInspector::Checklists::Environments
+      banner    "knife environment inspect [ENVIRONMENT] (options)"
     end
   end
 end

lib/chef/knife/role_inspect.rb

@@ -1,25 +1,13 @@
 require 'chef/knife'
+require 'health_inspector'
 
 class Chef
   class Knife
     class RoleInspect < Knife
+      include HealthInspector::Runner
 
-      deps do
-        require 'health_inspector'
-      end
-
-      banner "knife role inspect [ROLE] (options)"
-
-      def run
-        case @name_args.length
-        when 1 # We are inspecting a role
-          role_name = @name_args[0]
-          validator = HealthInspector::Checklists::Roles.new(self)
-          exit validator.validate_item( validator.load_item(role_name) )
-        when 0 # We are inspecting all the roles
-          exit HealthInspector::Checklists::Roles.run(self)
-        end
-      end
+      checklist HealthInspector::Checklists::Roles
+      banner    "knife role inspect [ROLE] (options)"
     end
   end
 end

lib/health_inspector.rb

@@ -3,6 +3,7 @@
 require "health_inspector/color"
 require "health_inspector/context"
 require "health_inspector/pairing"
+require "health_inspector/runner"
 require "health_inspector/checklists/base"
 require "health_inspector/checklists/cookbooks"
 require "health_inspector/checklists/data_bags"

lib/health_inspector/runner.rb

@@ -0,0 +1,28 @@
+module HealthInspector
+  module Runner
+    def self.included(base)
+      base.extend(ClassMethods)
+    end
+
+    module ClassMethods
+      attr_reader :checklist
+
+      def checklist(value = nil)
+        return @checklist if value.nil?
+
+        @checklist = value
+      end
+    end
+
+    def run
+      case @name_args.length
+      when 1 # We are inspecting an item
+        item = @name_args[0]
+        validator = self.class.checklist.new(self)
+        exit validator.validate_item(validator.load_item(item))
+      when 0 # We are inspecting all the items
+        exit self.class.checklist.run(self)
+      end
+    end
+  end
+end