Merge pull request #14 from gregkare/exit_status

Exit with the proper status (0 for success, 1 for failure)

Author: meatballhat

lib/chef/knife/cookbook_inspect.rb

@@ -22,9 +22,9 @@ def run
           # api_endpoint  = env ? "environments/#{env}/cookbooks/#{cookbook_name}" : "cookbooks/#{cookbook_name}"
 
           validator = HealthInspector::Checklists::Cookbooks.new(self)
-          validator.validate_item( validator.load_item(cookbook_name) )
+          exit validator.validate_item( validator.load_item(cookbook_name) )
         when 0 # We are inspecting all the cookbooks
-          HealthInspector::Checklists::Cookbooks.run(self)
+          exit HealthInspector::Checklists::Cookbooks.run(self)
         end
       end
     end

lib/chef/knife/data_bag_inspect.rb

@@ -17,17 +17,17 @@ def run
           item_name = @name_args[1]
 
           validator = HealthInspector::Checklists::DataBagItems.new(self)
-          validator.validate_item( validator.load_item("#{bag_name}/#{item_name}") )
+          exit validator.validate_item( validator.load_item("#{bag_name}/#{item_name}") )
 
         when 1 # We are inspecting a data bag
           bag_name = @name_args[0]
 
           validator = HealthInspector::Checklists::DataBags.new(self)
-          validator.validate_item( validator.load_item(bag_name) )
+          exit validator.validate_item( validator.load_item(bag_name) )
 
         when 0 # We are inspecting all the data bags
           HealthInspector::Checklists::DataBags.run(self)
-          HealthInspector::Checklists::DataBagItems.run(self)
+          exit HealthInspector::Checklists::DataBagItems.run(self)
         end
       end
     end

lib/chef/knife/environment_inspect.rb

@@ -15,9 +15,9 @@ def run
         when 1 # We are inspecting a environment
           environment_name = @name_args[0]
           validator = HealthInspector::Checklists::Environments.new(self)
-          validator.validate_item( validator.load_item(environment_name) )
+          exit validator.validate_item( validator.load_item(environment_name) )
         when 0 # We are inspecting all the environments
-          HealthInspector::Checklists::Environments.run(self)
+          exit HealthInspector::Checklists::Environments.run(self)
         end
       end
     end

lib/chef/knife/inspect.rb

@@ -4,16 +4,20 @@ class Chef
   class Knife
     class Inspect < Knife
 
+      CHECKLISTS = %w[Cookbooks DataBags DataBagItems Environments Roles]
+
       deps do
         require "health_inspector"
       end
 
       banner "knife inspect"
 
       def run
-        %w[ Cookbooks DataBags DataBagItems Environments Roles ].each do |checklist|
+        results = CHECKLISTS.map do |checklist|
           HealthInspector::Checklists.const_get(checklist).run(self)
         end
+
+        exit ! results.include?(false)
       end
     end
   end

lib/chef/knife/role_inspect.rb

@@ -15,9 +15,9 @@ def run
         when 1 # We are inspecting a role
           role_name = @name_args[0]
           validator = HealthInspector::Checklists::Roles.new(self)
-          validator.validate_item( validator.load_item(role_name) )
+          exit validator.validate_item( validator.load_item(role_name) )
         when 0 # We are inspecting all the roles
-          HealthInspector::Checklists::Roles.run(self)
+          exit HealthInspector::Checklists::Roles.run(self)
         end
       end
     end

lib/health_inspector/checklists/base.rb

@@ -41,9 +41,13 @@ def each_item
       def run
         banner "Inspecting #{self.class.title}"
 
+        results = []
+
         each_item do |item|
-          validate_item(item)
+          results << validate_item(item)
         end
+
+        return ! results.include?(false)
       end
 
       def validate_item(item)
@@ -52,8 +56,12 @@ def validate_item(item)
 
         if failures.empty?
           print_success(item.name) # unless @context.quiet_success
+
+          true
         else
           print_failures(item.name, failures)
+
+          false
         end
       end