Skip to content

Fix (lack of) building without C++11 support#497

Closed
grisumbras wants to merge 3 commits intoboostorg:developfrom
grisumbras:fix-cxx-03-build
Closed

Fix (lack of) building without C++11 support#497
grisumbras wants to merge 3 commits intoboostorg:developfrom
grisumbras:fix-cxx-03-build

Conversation

@grisumbras
Copy link
Copy Markdown
Member

No description provided.

@grisumbras
Copy link
Copy Markdown
Member Author

This should fix Boost builds without C++11 support

@vinniefalco
Copy link
Copy Markdown
Member

Suggested commit message: "Builds prior to C++11 are no-ops"

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2021

Codecov Report

Merging #497 (2f1c258) into develop (f0ea69f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #497   +/-   ##
========================================
  Coverage    99.10%   99.10%           
========================================
  Files           67       67           
  Lines         6047     6047           
========================================
  Hits          5993     5993           
  Misses          54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ea69f...ffc82d3. Read the comment docs.

@grisumbras
Copy link
Copy Markdown
Member Author

Do you think there's a need for CI test for no-op build with cxxstd=03?

@vinniefalco
Copy link
Copy Markdown
Member

Please change "Adds back GCC 4.8 support" to "gcc-4.8 is supported"

@vinniefalco
Copy link
Copy Markdown
Member

Do you think there's a need for CI test for no-op build with cxxstd=03?

Up to you

@cppalliance-bot
Copy link
Copy Markdown

@cppalliance-bot
Copy link
Copy Markdown

@vinniefalco
Copy link
Copy Markdown
Member

Can we please change the commit message to "gcc-4.8 is supported" ? Use an interactive rebase (git rebase -i) then force-push the branch.

@grisumbras
Copy link
Copy Markdown
Member Author

Which commit?

@vinniefalco
Copy link
Copy Markdown
Member

This one:
image

vinniefalco pushed a commit to vinniefalco/json that referenced this pull request Feb 9, 2021
@cppalliance-bot
Copy link
Copy Markdown

@grisumbras grisumbras deleted the fix-cxx-03-build branch March 10, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants