Refactoring of conversion functions by grisumbras · Pull Request #686 · boostorg/json

grisumbras · 2022-02-28T09:49:26Z

The list of changes:

take advantage of mp11
split container_traits into several traits and helpers
split map_traits into several traits
use value_type more consistently
refactor detail::inserter
use detail::inserter with map-like types
refactor conversion of tuple-like to array
remove conversion from value_ref and don't use value_to/from when constructing value from value_ref
check for round-trip
user-facing conversion traits
opt-in null-like conversion
same requirements for value_to and value_from
stricter is_map_like
stricter is_sequence_like

cppalliance-bot · 2022-02-28T11:23:21Z

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/686/pullrequest.html

cppalliance-bot · 2022-03-09T16:38:23Z

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/686/pullrequest.html

cppalliance-bot · 2022-05-15T09:59:43Z

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/686/pullrequest.html

cppalliance-bot · 2022-05-15T13:19:39Z

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/686/pullrequest.html

cppalliance-bot · 2022-08-12T14:49:39Z

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/686/pullrequest.html

codecov · 2022-08-12T18:39:08Z

Codecov Report

Merging #686 (ce144b5) into develop (9fc23d6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #686   +/-   ##
========================================
  Coverage    99.13%   99.13%           
========================================
  Files           69       69           
  Lines         6584     6587    +3     
========================================
+ Hits          6527     6530    +3     
  Misses          57       57

Impacted Files	Coverage Δ
include/boost/json/impl/value_ref.hpp	`100.00% <ø> (ø)`
include/boost/json/detail/value_from.hpp	`100.00% <100.00%> (ø)`
include/boost/json/detail/value_to.hpp	`100.00% <100.00%> (ø)`
include/boost/json/detail/value_traits.hpp	`100.00% <100.00%> (ø)`
include/boost/json/value_from.hpp	`100.00% <100.00%> (ø)`
include/boost/json/value_to.hpp	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc23d6...ce144b5. Read the comment docs.

cppalliance-bot · 2022-08-12T19:34:43Z

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/686/pullrequest.html

cppalliance-bot · 2022-08-13T09:54:44Z

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/686/pullrequest.html

cppalliance-bot · 2022-09-26T09:36:46Z

An automated preview of the documentation is available at https://686.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot · 2022-09-26T10:44:39Z

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/686/pullrequest.html

cppalliance-bot · 2022-09-29T09:06:27Z

An automated preview of the documentation is available at https://686.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot · 2022-09-29T09:21:31Z

An automated preview of the documentation is available at https://686.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot · 2022-09-29T09:36:29Z

An automated preview of the documentation is available at https://686.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot · 2022-09-29T09:56:28Z

An automated preview of the documentation is available at https://686.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot · 2022-09-29T10:06:29Z

An automated preview of the documentation is available at https://686.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot · 2022-09-29T11:14:34Z

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/686/pullrequest.html

vinniefalco · 2022-09-29T19:40:19Z

include/boost/json/conversion.hpp

+
+#include <utility>
+
+BOOST_JSON_NS_BEGIN


if we don't have standalone we don't need this namespace macro

All public header files need to be listed in <boost/json.hpp>, this one is missing (are any other new files missing?)

vinniefalco · 2022-09-29T19:40:45Z

include/boost/json/conversion.hpp

+#include <utility>
+
+BOOST_JSON_NS_BEGIN
+namespace detail {


Implementation details should be in json/detail or json/impl not a public header since this is scanned by doxygen

This stuff should go in <boost/json/detail/conversion.hpp>

vinniefalco · 2022-09-29T19:41:36Z

include/boost/json/conversion.hpp

+;
+#endif
+
+/** Determine if `T` can be treated like a 1-to-1 mapping during


Metafunction briefs should start with "Metafunction"

These aren't metafunctions, they are type traits.

it isn't a function taking a type as an argument and returning a value?

Metafunctions return types, these return boolean values, so they are type traits.

include/boost/json/conversion.hpp

include/boost/json/detail/value_to.hpp

test/value_to.cpp

vinniefalco · 2022-09-29T19:52:45Z

doc/qbk/quickref.xml

+          <member><link linkend="json.ref.boost__json__is_sequence_like">is_sequence_like</link></member>
+          <member><link linkend="json.ref.boost__json__is_map_like">is_map_like</link></member>
+          <member><link linkend="json.ref.boost__json__is_null_like">is_null_like</link></member>
+          <member><link linkend="json.ref.boost__json__is_tuple_like">is_tuple_like</link></member>


These are not in alphabetical order, was this intended?

No, it was a mistake

vinniefalco · 2022-09-29T19:53:57Z

This needs exposition in the docs

include/boost/json/conversion.hpp

vinniefalco · 2022-09-29T20:04:51Z

@pdimov did you review this?

grisumbras marked this pull request as draft February 28, 2022 09:50

grisumbras force-pushed the conversion-mp_cond branch 2 times, most recently from 83d26dc to 5471363 Compare February 28, 2022 10:11

grisumbras force-pushed the conversion-mp_cond branch 5 times, most recently from 7641c3f to a9c6df6 Compare March 9, 2022 15:25

grisumbras force-pushed the conversion-mp_cond branch 3 times, most recently from 2c1545d to 37a7594 Compare May 15, 2022 08:47

grisumbras force-pushed the conversion-mp_cond branch 3 times, most recently from 5e13585 to 0cbfc1f Compare May 15, 2022 12:04

grisumbras force-pushed the conversion-mp_cond branch from 0cbfc1f to ae65a1e Compare August 12, 2022 12:38

grisumbras force-pushed the conversion-mp_cond branch 5 times, most recently from 565943c to 018f286 Compare August 12, 2022 18:20

grisumbras force-pushed the conversion-mp_cond branch 2 times, most recently from 9c7f931 to 1e57a31 Compare August 13, 2022 08:40

grisumbras force-pushed the conversion-mp_cond branch from 2c66059 to b139626 Compare September 26, 2022 09:30

grisumbras added 2 commits September 26, 2022 18:22

tightening is_sequence_like

ce83fcb

tests for conversion traits

77a2183

grisumbras force-pushed the conversion-mp_cond branch from b139626 to 77a2183 Compare September 29, 2022 08:57

grisumbras force-pushed the conversion-mp_cond branch from 42d6357 to 510c4d5 Compare September 29, 2022 09:30

grisumbras force-pushed the conversion-mp_cond branch from 510c4d5 to ee66d56 Compare September 29, 2022 09:50

hide mismatched-tags warning

ce144b5

grisumbras force-pushed the conversion-mp_cond branch from ee66d56 to ce144b5 Compare September 29, 2022 09:58

grisumbras merged commit ce144b5 into boostorg:develop Sep 29, 2022

grisumbras deleted the conversion-mp_cond branch September 29, 2022 12:46

vinniefalco reviewed Sep 29, 2022

View reviewed changes

include/boost/json/conversion.hpp Show resolved Hide resolved

vinniefalco reviewed Sep 29, 2022

View reviewed changes

include/boost/json/conversion.hpp Show resolved Hide resolved

vinniefalco reviewed Sep 29, 2022

View reviewed changes

include/boost/json/detail/value_to.hpp Show resolved Hide resolved

vinniefalco reviewed Sep 29, 2022

View reviewed changes

test/value_to.cpp Show resolved Hide resolved

vinniefalco reviewed Sep 29, 2022

View reviewed changes

include/boost/json/conversion.hpp Show resolved Hide resolved

grisumbras mentioned this pull request Oct 19, 2022

Refactor conversion implementation #777

Merged


		#include <utility>

		BOOST_JSON_NS_BEGIN

Conversation

grisumbras commented Feb 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cppalliance-bot commented Feb 28, 2022

Uh oh!

cppalliance-bot commented Mar 9, 2022

Uh oh!

cppalliance-bot commented May 15, 2022

Uh oh!

cppalliance-bot commented May 15, 2022

Uh oh!

cppalliance-bot commented Aug 12, 2022

Uh oh!

codecov bot commented Aug 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cppalliance-bot commented Aug 12, 2022

Uh oh!

cppalliance-bot commented Aug 13, 2022

Uh oh!

cppalliance-bot commented Sep 26, 2022

Uh oh!

cppalliance-bot commented Sep 26, 2022

Uh oh!

cppalliance-bot commented Sep 29, 2022

Uh oh!

cppalliance-bot commented Sep 29, 2022

Uh oh!

cppalliance-bot commented Sep 29, 2022

Uh oh!

cppalliance-bot commented Sep 29, 2022

Uh oh!

cppalliance-bot commented Sep 29, 2022

Uh oh!

cppalliance-bot commented Sep 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vinniefalco Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vinniefalco commented Sep 29, 2022

Uh oh!

Uh oh!

vinniefalco commented Sep 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

grisumbras commented Feb 28, 2022 •

edited

Loading

codecov bot commented Aug 12, 2022 •

edited

Loading

vinniefalco Sep 29, 2022 •

edited

Loading