fixed rendering invalid color name #2872

Author: liborm85

CHANGELOG.md

@@ -12,6 +12,7 @@
 	});
 	```
 - Fixed extra blank page when using headerRows, dontBreakRows and cell pageBreak together
+- Fixed rendering of an invalid color name - previously it used the last valid color; now it defaults to black
 
 ## 0.3.7 - 2026-03-17
 

src/PDFDocument.js

@@ -169,6 +169,18 @@ class PDFDocument extends PDFKit {
 		return attachment;
 	}
 
+	resolveColor(color, defaultColor) {
+		color = color || defaultColor;
+
+		if (typeof this._normalizeColor === 'function') {
+			if (this._normalizeColor(color) === null) { // color is not valid
+				return defaultColor;
+			}
+		}
+
+		return color;
+	}
+
 	setOpenActionAsPrint() {
 		let printActionRef = this.ref({
 			Type: 'Action',

src/Renderer.js

@@ -188,7 +188,7 @@ class Renderer {
 
 			let opacity = isNumber(inline.opacity) ? inline.opacity : 1;
 			this.pdfDocument.opacity(opacity);
-			this.pdfDocument.fill(inline.color || 'black');
+			this.pdfDocument.fill(this.pdfDocument.resolveColor(inline.color, 'black'));
 
 			this.pdfDocument._font = inline.font;
 			this.pdfDocument.fontSize(inline.fontSize);
@@ -287,14 +287,14 @@ class Renderer {
 		let strokeOpacity = isNumber(vector.strokeOpacity) ? vector.strokeOpacity : 1;
 
 		if (vector.color && vector.lineColor) {
-			this.pdfDocument.fillColor(vector.color, fillOpacity);
-			this.pdfDocument.strokeColor(vector.lineColor, strokeOpacity);
+			this.pdfDocument.fillColor(this.pdfDocument.resolveColor(vector.color, 'black'), fillOpacity);
+			this.pdfDocument.strokeColor(this.pdfDocument.resolveColor(vector.lineColor, 'black'), strokeOpacity);
 			this.pdfDocument.fillAndStroke();
 		} else if (vector.color) {
-			this.pdfDocument.fillColor(vector.color, fillOpacity);
+			this.pdfDocument.fillColor(this.pdfDocument.resolveColor(vector.color, 'black'), fillOpacity);
 			this.pdfDocument.fill();
 		} else {
-			this.pdfDocument.strokeColor(vector.lineColor || 'black', strokeOpacity);
+			this.pdfDocument.strokeColor(this.pdfDocument.resolveColor(vector.lineColor, 'black'), strokeOpacity);
 			this.pdfDocument.stroke();
 		}
 	}
@@ -436,7 +436,7 @@ class Renderer {
 	renderWatermark(page) {
 		let watermark = page.watermark;
 
-		this.pdfDocument.fill(watermark.color);
+		this.pdfDocument.fill(this.pdfDocument.resolveColor(watermark.color, 'black'));
 		this.pdfDocument.opacity(watermark.opacity);
 
 		this.pdfDocument.save();

tests/unit/PDFDocument.spec.js

@@ -57,4 +57,29 @@ describe('PDFDocument', function () {
 		// TODO
 
 	});
+
+	describe('resolveColor', function () {
+
+		it('should resolve valid color name', function () {
+			assert.equal(pdfDocument.resolveColor('red'), 'red');
+		});
+
+		it('should resolve default color', function () {
+			assert.equal(pdfDocument.resolveColor(undefined, 'red'), 'red');
+		});
+
+		it('should resolve hex color', function () {
+			 assert.equal(pdfDocument.resolveColor('#f900f8'), '#f900f8');
+		});
+
+		it('should resolve invalid color name', function () {
+			assert.equal(pdfDocument.resolveColor('invalid'), null);
+		});
+
+		it('should resolve invalid color name with default', function () {
+			assert.equal(pdfDocument.resolveColor('invalid', 'red'), 'red');
+		});
+
+	});
+
 });