Fixed FTP remote creation.

Author: FezVrasta

htmlContent/git-remotes-picker.html

@@ -1,5 +1,5 @@
 <!-- List of remotes defined for the current local repository -->
-{{#gitFtpEnabled}}<li class="dropdown-header">{{Strings.GIT_REMOTES}}</li>{{/gitFtpEnabled}}
+{{#gitFtpEnabled}}<li class="dropdown-header git-remotes-header">{{Strings.GIT_REMOTES}}</li>{{/gitFtpEnabled}}
 {{#hasRemotes}}
 {{#remotes}}
 <li class="remote">
@@ -15,7 +15,7 @@
 {{#gitFtpEnabled}}
 <!-- List of Git-FTP remotes defined for the current local repository -->
 <li class="divider"></li>
-<li class="dropdown-header">{{Strings.GITFTP_REMOTES}}</li>
+<li class="dropdown-header ftp-remotes-header">{{Strings.GITFTP_REMOTES}}</li>
 {{#hasFtpRemotes}}
 {{#ftpRemotes}}
 <li class="gitftp-remote">

src/Ftp.js

@@ -57,24 +57,48 @@ define(function (require) {
             .addClass("btn-loading")
             .prop("disabled", true);
 
-        return Utils.askQuestion(Strings.CREATE_GITFTP_NEW_REMOTE,
-                                 Strings.ENTER_GITFTP_REMOTE_NAME).then(function (name) {
-            return Utils.askQuestion(Strings.CREATE_GITFTP_NEW_REMOTE,
-                                     Strings.ENTER_GITFTP_REMOTE_URL,
-                                     {defaultValue: "ftp://user:passwd@example.org/folder"}).then(function (url) {
-                
-                return GitFtp.addScope(name, url).then(function () {
-                    // return handleGitFtpRemoteInit();
-                }).fail(function (err) {
-                    ErrorHandler.showError(err, "Git-FTP remote creation failed");
-                });
-                
+        return Utils.askQuestion(Strings.CREATE_GITFTP_NEW_REMOTE, Strings.ENTER_GITFTP_REMOTE_NAME)
+            .then(function (name) {
+                return Utils.askQuestion(
+                    Strings.CREATE_GITFTP_NEW_REMOTE,
+                    Strings.ENTER_GITFTP_REMOTE_URL,
+                    {defaultValue: "ftp://user:passwd@example.org/folder"}
+                )
+                    .then(function (url) {
+                        return GitFtp.addScope(name, url).then(function () {
+
+                            // Render the list element of the new remote
+                            // TODO: replace this part with a way to call `Remotes.refreshRemotesPicker()`
+                            var $newRemote =   $("<li/>")
+                                                    .addClass("gitftp-remote")
+                                                    .append("<a/>")
+                                                    .find("a")
+                                                        .attr({href: "#", "data-remote-name": name, "data-type": "ftp"})
+                                                        .addClass("remote-name")
+                                                        .append("<span/>")
+                                                        .find("span")
+                                                            .addClass("trash-icon gitftp-remove-remote")
+                                                            .html("&times;")
+                                                        .end()
+                                                        .append("<span/>")
+                                                        .find("span:nth-child(2)")
+                                                            .addClass("change-remote")
+                                                            .text(name)
+                                                        .end()
+                                                    .end();
+
+                            $gitPanel.find(".git-remotes-dropdown .ftp-remotes-header").after($newRemote);
+
+                        }).fail(function (err) {
+                            ErrorHandler.showError(err, "Git-FTP remote creation failed");
+                        });
+                    });
+            })
+            .finally(function () {
+                $gitPanel.find(".git-remotes")
+                    .removeClass("btn-loading")
+                    .prop("disabled", false);
             });
-        }).finally(function () {
-            $gitPanel.find(".git-remotes")
-                .removeClass("btn-loading")
-                .prop("disabled", false);
-        });
     }
 
     function handleGitFtpRemoteRemove($this) {

src/Remotes.js

@@ -75,6 +75,8 @@ define(function (require) {
     }
 
     function refreshRemotesPicker() {
+
+        // TODO: replace `settle` with `all` applying [this](https://github.com/zaggino/brackets-git/pull/288#issuecomment-38674930)
         // Run both getRemotes and getFtpRemotes and render with Mustache the template
         Promise.settle([Git.getRemotes(), GitFtp.getRemotes()]).spread(function (remotes, ftpRemotes) {