fix(core): Add 'PSObject.Copy()' to 'substitute()' (ScoopInstaller#5962)

niheaven · brian6932 · commit 344b39a5313d · 2024-06-01T09:16:21.000-04:00
diff --git a/lib/autoupdate.ps1 b/lib/autoupdate.ps1
@@ -365,7 +365,7 @@ function Update-ManifestProperty {
                 }
             } elseif ($Manifest.$currentProperty -and $Manifest.autoupdate.$currentProperty) {
                 # Update other property (global)
-                $autoupdateProperty = $Manifest.autoupdate.$currentProperty.PSObject.Copy()
+                $autoupdateProperty = $Manifest.autoupdate.$currentProperty
                 $newValue = substitute $autoupdateProperty $Substitutions
                 if (($autoupdateProperty.GetType().Name -eq 'Object[]') -and ($autoupdateProperty.Length -eq 1)) {
                     # Make sure it's an array

Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,7 @@ function Update-ManifestProperty {`
`365`	`365`	`}`
`366`	`366`	`} elseif ($Manifest.$currentProperty -and $Manifest.autoupdate.$currentProperty) {`
`367`	`367`	`# Update other property (global)`
`368`		`- $autoupdateProperty = $Manifest.autoupdate.$currentProperty.PSObject.Copy()`
	`368`	`+ $autoupdateProperty = $Manifest.autoupdate.$currentProperty`
`369`	`369`	`$newValue = substitute $autoupdateProperty $Substitutions`
`370`	`370`	`if (($autoupdateProperty.GetType().Name -eq 'Object[]') -and ($autoupdateProperty.Length -eq 1)) {`
`371`	`371`	`# Make sure it's an array`