Skip to content

Commit 42266d4

Browse files
authored
Remove incorrect noop in unix stack pool management (#13069)
This commit removes a call to `commit_pages` in the `unix_stack_pool.rs` file. This function is a noop on unix and the parameters passed in for this call were also incorrect if it actually needed to do something anyway. This is otherwise just distracting, so remove it.
1 parent 66239cb commit 42266d4

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

crates/wasmtime/src/runtime/vm/instance/allocator/pooling/unix_stack_pool.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
use super::index_allocator::{SimpleIndexAllocator, SlotId};
44
use crate::prelude::*;
5-
use crate::runtime::vm::sys::vm::commit_pages;
65
use crate::runtime::vm::{
76
HostAlignedByteCount, Mmap, PoolingInstanceAllocatorConfig, mmap::AlignedLength,
87
};
@@ -121,8 +120,6 @@ impl StackPool {
121120
.add(self.stack_size.unchecked_mul(index).byte_count())
122121
.cast_mut();
123122

124-
commit_pages(bottom_of_stack, size_without_guard.byte_count())?;
125-
126123
let stack = wasmtime_fiber::FiberStack::from_raw_parts(
127124
bottom_of_stack,
128125
self.page_size.byte_count(),

0 commit comments

Comments
 (0)