Skip to content

Commit 0e829bc

Browse files
authored
caddyhttp: Fix listener wrapper regression from #6573 (#6599)
1 parent 4b1a9b6 commit 0e829bc

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

listeners.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,14 +183,14 @@ func (na NetworkAddress) listen(ctx context.Context, portOffset uint, config net
183183
}
184184
}
185185

186-
if ln == nil {
187-
return nil, fmt.Errorf("unsupported network type: %s", na.Network)
188-
}
189-
190186
if err != nil {
191187
return nil, err
192188
}
193189

190+
if ln == nil {
191+
return nil, fmt.Errorf("unsupported network type: %s", na.Network)
192+
}
193+
194194
if IsUnixNetwork(na.Network) {
195195
isAbstractUnixSocket := strings.HasPrefix(address, "@")
196196
if !isAbstractUnixSocket {

modules/caddyhttp/app.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -535,11 +535,6 @@ func (app *App) Start() error {
535535
return fmt.Errorf("network '%s' cannot handle HTTP/1 or HTTP/2 connections", listenAddr.Network)
536536
}
537537

538-
if useTLS {
539-
// create TLS listener - this enables and terminates TLS
540-
ln = tls.NewListener(ln, tlsCfg)
541-
}
542-
543538
// wrap listener before TLS (up to the TLS placeholder wrapper)
544539
var lnWrapperIdx int
545540
for i, lnWrapper := range srv.listenerWrappers {
@@ -550,6 +545,11 @@ func (app *App) Start() error {
550545
ln = lnWrapper.WrapListener(ln)
551546
}
552547

548+
if useTLS {
549+
// create TLS listener - this enables and terminates TLS
550+
ln = tls.NewListener(ln, tlsCfg)
551+
}
552+
553553
// finish wrapping listener where we left off before TLS
554554
for i := lnWrapperIdx; i < len(srv.listenerWrappers); i++ {
555555
ln = srv.listenerWrappers[i].WrapListener(ln)

0 commit comments

Comments
 (0)