Skip to content

Commit 0f7f8e9

Browse files
authored
forwardauth: error on duplicate uri subdirective (#7814)
1 parent 4fd8c87 commit 0f7f8e9

2 files changed

Lines changed: 17 additions & 1 deletion

File tree

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
localhost:9080 {
2+
forward_auth :9091 {
3+
uri /first
4+
uri /second
5+
copy_headers Remote-User
6+
}
7+
8+
respond "ok" 200
9+
}
10+
11+
----------
12+
parsing caddyfile tokens for 'forward_auth': cannot re-declare uri: /second

modules/caddyhttp/reverseproxy/forwardauth/caddyfile.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,11 @@ func parseCaddyfile(h httpcaddyfile.Helper) ([]httpcaddyfile.ConfigValue, error)
129129
if !dispenser.NextArg() {
130130
return nil, dispenser.ArgErr()
131131
}
132-
rpHandler.Rewrite.URI = dispenser.Val()
132+
uri := dispenser.Val()
133+
if rpHandler.Rewrite.URI != "" {
134+
return nil, dispenser.Errf("cannot re-declare uri: %s", uri)
135+
}
136+
rpHandler.Rewrite.URI = uri
133137
dispenser.DeleteN(2)
134138

135139
case "copy_headers":

0 commit comments

Comments
 (0)