caddyhttp: Make route provisioning idempotent (#6558)

jbro · web-flow · commit 91e62db666b7 · 2024-09-03T11:57:55.000-06:00
ref: #6551
diff --git a/modules/caddyhttp/routes.go b/modules/caddyhttp/routes.go
@@ -159,6 +159,9 @@ func (r *Route) ProvisionHandlers(ctx caddy.Context, metrics *Metrics) error {
 		r.Handlers = append(r.Handlers, handler.(MiddlewareHandler))
 	}
 
+	// Make ProvisionHandlers idempotent by clearing the middleware field
+	r.middleware = []Middleware{}
+
 	// pre-compile the middleware handler chain
 	for _, midhandler := range r.Handlers {
 		r.middleware = append(r.middleware, wrapMiddleware(ctx, midhandler, metrics))

Original file line number	Diff line number	Diff line change
`@@ -159,6 +159,9 @@ func (r Route) ProvisionHandlers(ctx caddy.Context, metrics Metrics) error {`
`159`	`159`	`r.Handlers = append(r.Handlers, handler.(MiddlewareHandler))`
`160`	`160`	`}`
`161`	`161`
	`162`	`+ // Make ProvisionHandlers idempotent by clearing the middleware field`
	`163`	`+ r.middleware = []Middleware{}`
	`164`	`+`
`162`	`165`	`// pre-compile the middleware handler chain`
`163`	`166`	`for _, midhandler := range r.Handlers {`
`164`	`167`	`r.middleware = append(r.middleware, wrapMiddleware(ctx, midhandler, metrics))`