reverseproxy: Only log host is up status on change (fixes #6415)

klaxa · klaxa · commit b1b68b652379 · 2024-07-01T17:28:47.000+02:00
diff --git a/modules/caddyhttp/reverseproxy/healthchecks.go b/modules/caddyhttp/reverseproxy/healthchecks.go
@@ -426,6 +426,7 @@ func (h *Handler) doActiveHealthCheck(dialInfo DialInfo, hostAddr string, upstre
 		}
 		if upstream.Host.activeHealthPasses() >= h.HealthChecks.Active.Passes {
 			if upstream.setHealthy(true) {
+				h.HealthChecks.Active.logger.Info("host is up", zap.String("host", hostAddr))
 				h.events.Emit(h.ctx, "healthy", map[string]any{"host": hostAddr})
 				upstream.Host.resetHealth()
 			}
@@ -492,7 +493,6 @@ func (h *Handler) doActiveHealthCheck(dialInfo DialInfo, hostAddr string, upstre
 	}
 
 	// passed health check parameters, so mark as healthy
-	h.HealthChecks.Active.logger.Info("host is up", zap.String("host", hostAddr))
 	markHealthy()
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -426,6 +426,7 @@ func (h *Handler) doActiveHealthCheck(dialInfo DialInfo, hostAddr string, upstre`
`426`	`426`	`}`
`427`	`427`	`if upstream.Host.activeHealthPasses() >= h.HealthChecks.Active.Passes {`
`428`	`428`	`if upstream.setHealthy(true) {`
	`429`	`+ h.HealthChecks.Active.logger.Info("host is up", zap.String("host", hostAddr))`
`429`	`430`	`h.events.Emit(h.ctx, "healthy", map[string]any{"host": hostAddr})`
`430`	`431`	`upstream.Host.resetHealth()`
`431`	`432`	`}`
`@@ -492,7 +493,6 @@ func (h *Handler) doActiveHealthCheck(dialInfo DialInfo, hostAddr string, upstre`
`492`	`493`	`}`
`493`	`494`
`494`	`495`	`// passed health check parameters, so mark as healthy`
`495`		`- h.HealthChecks.Active.logger.Info("host is up", zap.String("host", hostAddr))`
`496`	`496`	`markHealthy()`
`497`	`497`
`498`	`498`	`return nil`