WD-17150 - Fix linting and test

Author: alvaromateo

tests/store/tests_details.py

@@ -149,23 +149,14 @@ def test_extra_details_404(self):
                 status=404,
             )
         )
-        metrics_url = "https://api.snapcraft.io/api/v1/snaps/metrics"
-        responses.add(
-            responses.Response(
-                method="POST", url=metrics_url, json={}, status=200
-            )
-        )
 
         response = self.client.get(self.endpoint_url)
 
-        assert len(responses.calls) == 3
+        assert len(responses.calls) == 2
         assert responses.calls[0].request.url == self.api_url
         assert responses.calls[1].request.url == self.api_url_details
-        assert responses.calls[2].request.url == metrics_url
 
-        self.assert200(response)
-        self.assert_not_in_context("aliases")
-        self.assert_context("snap-id", "id")
+        assert response.status_code == 404
 
     @responses.activate
     def test_api_500(self):

webapp/api/requests.py

@@ -29,10 +29,6 @@ def __init__(self, *args, **kwargs):
 
     def request(self, method, url, timeout=12, **kwargs):
         try:
-            print("Sending request to Store API")
-            print(url)
-            print(self.headers)
-            print(self.cookies)
             return super().request(
                 method=method, url=url, timeout=timeout, **kwargs
             )

webapp/store/snap_details_views.py

@@ -1,6 +1,5 @@
 import flask
 from flask import Response
-import requests
 
 import humanize
 import os
@@ -213,19 +212,9 @@ def snap_details(snap_name):
         status_code = 200
 
         context = _get_context_snap_details(snap_name)
-        print(f"DEBUGGING: {snap_name}")
-        try:
-            extra_details = device_gateway.get_snap_details(
-                snap_name, fields=FIELDS_EXTRA_DETAILS
-            )
-        except Exception as e:
-            print(e)
-            response = requests.get(
-                f"https://api.snapcraft.io/api/v1/snaps/details/{snap_name}?fields=aliases",
-                headers={"X-Ubuntu-Series": "16"})
-            print(response.status_code)
-            print(response.text)
-            print("END_DEBUGGING")
+        extra_details = device_gateway.get_snap_details(
+            snap_name, fields=FIELDS_EXTRA_DETAILS
+        )
 
         if extra_details and extra_details["aliases"]:
             context["aliases"] = [