Fix Python/JS/styles tests/linting on CI (#5586)

* fix: revert responses package to 0.22.0

* fix: run `test-python` job when requirements.txt changes

* fix: run `lint-python` job when requirements.txt changes

* fix: formatting

* fix: run `test-js` and `lint-js` when package.json and yarn.lock change

* fix: pass `lint-scss` check

* fix: style lint

* fix: better names for filters

* fix: check filters properly this time

* fix: move the path check at job level

* fix: add vitest config to checked files

* chore: format eslint config to trigger js checks

* fix: yarn.lock

* fix: add other pr dependencies

Author: edisile

.github/workflows/pr.yml

@@ -74,91 +74,100 @@ jobs:
           docker run --network="host" -v .:/app cypress/base:22.18.0 \
             bash "-c" "cd /app && npx cypress install && yarn run test-e2e"
 
+  changes:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: read
+    outputs:
+      py: ${{ steps.filter.outputs.py }}
+      js: ${{ steps.filter.outputs.js }}
+      scss: ${{ steps.filter.outputs.scss }}
+    steps:
+    - uses: dorny/paths-filter@v3
+      id: filter
+      with:
+        filters: |
+          py:
+            - '**/*.py'
+            - 'requirements.txt'
+            - 'templates/**/*'
+          js:
+            - '**/*.js'
+            - '**/*.ts'
+            - '**/*.jsx'
+            - '**/*.tsx'
+            - 'package.json'
+            - 'yarn.lock'
+            - 'eslint.config.mjs'
+            - 'vitest.config.js'
+            - 'vite.config.js'
+            - 'tsconfig.json'
+            - 'babel.config.json'
+          scss:
+            - '**/*.scss'
+            - '.stylelintrc'
+            - 'package.json'
+            - 'yarn.lock'
+
   lint-python:
+    needs: changes
+    if: ${{ needs.changes.outputs.py == 'true' }}
     runs-on: ubuntu-latest
     permissions:
       contents: read
     steps:
       - name: Checkout
         uses: actions/checkout@v6
-      - uses: dorny/paths-filter@v3
-        id: filter
-        with:
-          filters: |
-            py:
-              - '**/*.py'
 
       - name: Install dotrun
-        if: ${{ steps.filter.outputs.py == 'true' }}
         run: sudo pip3 install dotrun
 
       - name: Install dependencies
-        if: ${{ steps.filter.outputs.py == 'true' }}
         run: |
           sudo chmod -R 777 .
           dotrun install
 
       - name: Build assets
-        if: ${{ steps.filter.outputs.py == 'true' }}
         run: dotrun build
 
       - name: Lint python
-        if: ${{ steps.filter.outputs.py == 'true' }}
         run: dotrun lint-python
 
   lint-scss:
+    needs: changes
+    if: ${{ needs.changes.outputs.scss == 'true' }}
     runs-on: ubuntu-latest
     permissions:
       contents: read
     steps:
       - name: Checkout
         uses: actions/checkout@v6
 
-      - uses: dorny/paths-filter@v3
-        id: filter
-        with:
-          filters: |
-            scss:
-              - '**/*.scss'
-
       - name: Install SCSS dependencies
-        if: ${{ steps.filter.outputs.scss == 'true' }}
         run: yarn install --immutable
 
       - name: Lint SCSS
-        if: ${{ steps.filter.outputs.scss == 'true' }}
         run: yarn lint-scss
 
   lint-js:
+    needs: changes
+    if: ${{ needs.changes.outputs.js == 'true' }}
     runs-on: ubuntu-latest
     permissions:
       contents: read
     steps:
       - name: Checkout
         uses: actions/checkout@v6
 
-      - uses: dorny/paths-filter@v3
-        id: filter
-        with:
-          filters: |
-            js:
-              - '**/*.js'
-            ts:
-              - '**/*.ts'
-            jsx:
-              - '**/*.jsx'
-            tsx:
-              - '**/*.tsx'
-
       - name: Install JS dependencies
-        if: ${{ steps.filter.outputs.js == 'true' || steps.filter.outputs.ts == 'true' || steps.filter.outputs.jsx == 'true' || steps.filter.outputs.tsx == 'true' }}
         run: yarn install --immutable
 
       - name: Lint JS
-        if: ${{ steps.filter.outputs.js == 'true' || steps.filter.outputs.ts == 'true' || steps.filter.outputs.jsx == 'true' || steps.filter.outputs.tsx == 'true' }}
         run: yarn lint-js
 
   test-python:
+    needs: changes
+    if: ${{ needs.changes.outputs.py == 'true' }}
     runs-on: ubuntu-latest
     permissions:
       pull-requests: write
@@ -167,76 +176,49 @@ jobs:
     steps:
       - uses: actions/checkout@v6
 
-      - uses: dorny/paths-filter@v3
-        id: filter
-        with:
-          filters: |
-            py:
-              - '**/*.py'
-
       - name: Install dotrun
-        if: ${{ steps.filter.outputs.py == 'true' }}
         run: sudo pip3 install dotrun
 
       - name: Install dependencies
-        if: ${{ steps.filter.outputs.py == 'true' }}
         run: |
           sudo chmod -R 777 .
           dotrun install
 
       - name: Install dependencies
-        if: ${{ steps.filter.outputs.py == 'true' }}
         run: sudo pip3 install coverage
 
       - name: Build resources
-        if: ${{ steps.filter.outputs.py == 'true' }}
         run: dotrun build
 
       - name: Run python tests with coverage
-        if: ${{ steps.filter.outputs.py == 'true' }}
         run: dotrun test-python-job
 
       - name: Upload coverage to Codecov
-        if: ${{ steps.filter.outputs.py == 'true' }}
         uses: codecov/codecov-action@v5
         with:
           flags: python
 
   test-js:
+    needs: changes
+    if: ${{ needs.changes.outputs.js == 'true' }}
     runs-on: ubuntu-latest
     permissions:
       contents: read
     steps:
       - uses: actions/checkout@v6
 
-      - uses: dorny/paths-filter@v3
-        id: filter
-        with:
-          filters: |
-            js:
-              - '**/*.js'
-            ts:
-              - '**/*.ts'
-            jsx:
-              - '**/*.jsx'
-            tsx:
-              - '**/*.tsx'
-
       - uses: actions/setup-node@v6
         with:
           node-version: 24
 
       - name: Install dependencies
-        if: ${{ steps.filter.outputs.js == 'true' || steps.filter.outputs.ts == 'true' || steps.filter.outputs.jsx == 'true' || steps.filter.outputs.tsx == 'true' }}
         run: yarn install --immutable
 
       - name: Run JS tests with coverage
-        if: ${{ steps.filter.outputs.js == 'true' || steps.filter.outputs.ts == 'true' || steps.filter.outputs.jsx == 'true' || steps.filter.outputs.tsx == 'true' }}
         run: |
           yarn test-js --coverage
 
       - name: Upload coverage to Codecov
-        if: ${{ steps.filter.outputs.js == 'true' || steps.filter.outputs.ts == 'true' || steps.filter.outputs.jsx == 'true' || steps.filter.outputs.tsx == 'true' }}
         uses: codecov/codecov-action@v5
         with:
           flags: javascript

.stylelintrc

@@ -16,6 +16,7 @@
     "scss/no-global-function-names": null,
     "declaration-block-no-redundant-longhand-properties": null,
     "selector-not-notation": null,
+    "color-function-alias-notation": null,
     "at-rule-no-unknown": [
       true,
       {

eslint.config.mjs

@@ -1,4 +1,4 @@
-import vitest from '@vitest/eslint-plugin'
+import vitest from "@vitest/eslint-plugin";
 import react from "eslint-plugin-react";
 import prettier from "eslint-plugin-prettier";
 import jsxA11Y from "eslint-plugin-jsx-a11y";
@@ -48,7 +48,7 @@ export default [
         Object.entries({
           ...globals.browser,
           ...globals.node,
-          ...vitest.environments.env.globals
+          ...vitest.environments.env.globals,
         }).map(([key, value]) => [key.trim(), value]),
       ),
       parser: babelParser,
@@ -103,4 +103,3 @@ export default [
     },
   },
 ];
-

requirements.txt

@@ -21,7 +21,7 @@ pycountry==24.6.1
 pymacaroons==0.13.0
 python-dateutil==2.9.0.post0
 requests==2.32.5
-responses==0.25.8
+responses==0.22.0
 ruamel.yaml==0.18.5
 vcrpy-unittest==0.1.7
 user-agents==2.2.0

static/sass/_snapcraft_p-release-details-row.scss

@@ -8,10 +8,10 @@
     }
 
     &__progress {
+      column-gap: 0.5rem;
       display: grid;
       flex: 1;
       font-weight: 400;
-      grid-column-gap: 0.5rem;
       grid-template-columns: auto 8rem;
     }
 

tests/api/test_marketo_api.py

@@ -8,7 +8,6 @@
 # Local modules
 import webapp.api.marketo as marketo_api
 
-
 responses.mock.assert_all_requests_are_fired = True
 
 

tests/endpoints/tests_models.py

@@ -8,7 +8,6 @@
 from webapp.helpers import api_publisher_session
 from tests.endpoints.endpoint_testing import TestModelServiceEndpoints
 
-
 candid = CandidClient(api_publisher_session)
 
 

webapp/admin/views.py

@@ -10,7 +10,6 @@
 from webapp.decorators import login_required, exchange_required
 from webapp.helpers import api_publisher_session, api_session
 
-
 dashboard = Dashboard(api_session)
 publisher_gateway = PublisherGW("snap", api_publisher_session)
 device_gateway = DeviceGW("snap", api_session)

webapp/endpoints/builds.py

@@ -5,7 +5,6 @@
 import flask
 from canonicalwebteam.store_api.dashboard import Dashboard
 
-
 # Local
 from webapp.helpers import api_publisher_session, launchpad
 from webapp.api.github import GitHub

webapp/endpoints/invites.py

@@ -11,7 +11,6 @@
 from webapp.decorators import login_required, exchange_required
 from webapp.helpers import api_session
 
-
 dashboard = Dashboard(api_session)
 
 invites = flask.Blueprint(