TS types for reducers (#5495)

* feature: TS types for reducers

* fix: remove useless `any` annotations

Author: edisile

static/js/publisher/pages/Releases/reducers/architectures.js

@@ -0,0 +1,20 @@
+import { UPDATE_ARCHITECTURES } from "../actions/architectures";
+import {
+  ReleasesAction,
+  ReleasesReduxState,
+} from "../../../types/releaseTypes";
+
+type UpdateArchitecturesAction = ReleasesAction & {
+  payload: {
+    architectures: ReleasesReduxState["architectures"];
+  };
+};
+
+export default function architectures(state: ReleasesReduxState["architectures"] = [], action: UpdateArchitecturesAction) {
+  switch (action.type) {
+    case UPDATE_ARCHITECTURES:
+      return [...action.payload.architectures];
+    default:
+      return state;
+  }
+}

static/js/publisher/pages/Releases/reducers/architectures.ts

@@ -0,0 +1,25 @@
+import { AVAILABLE_REVISIONS_SELECT_UNRELEASED } from "../constants";
+import { SET_AVAILABLE_REVISIONS_SELECT } from "../actions/availableRevisionsSelect";
+import {
+  AvailableRevisionsSelect,
+  ReleasesAction,
+  ReleasesReduxState,
+} from "../../../types/releaseTypes";
+
+type AvailableRevisionsSelectAction = ReleasesAction & {
+  payload: {
+    value: AvailableRevisionsSelect;
+  };
+};
+
+export default function availableRevisionsSelect(
+  state: ReleasesReduxState["availableRevisionsSelect"] = AVAILABLE_REVISIONS_SELECT_UNRELEASED,
+  action: AvailableRevisionsSelectAction
+) {
+  switch (action.type) {
+    case SET_AVAILABLE_REVISIONS_SELECT:
+      return action.payload.value;
+    default:
+      return state;
+  }
+}

static/js/publisher/pages/Releases/reducers/availableRevisionsSelect.js

@@ -1,6 +1,17 @@
+import {
+  ReleasesAction,
+  ReleasesReduxState,
+} from "../../../types/releaseTypes";
 import { OPEN_BRANCHES, CLOSE_BRANCHES } from "../actions/branches";
 
-export default function branches(state = [], action) {
+type BranchesAction = ReleasesAction & {
+  payload: string;
+};
+
+export default function branches(
+  state: ReleasesReduxState["branches"] = [],
+  action: BranchesAction
+) {
   switch (action.type) {
     case OPEN_BRANCHES: {
       const newState = state.slice(0);

static/js/publisher/pages/Releases/reducers/availableRevisionsSelect.ts

@@ -6,8 +6,48 @@ import {
   RELEASE_REVISION_SUCCESS,
   CLOSE_CHANNEL_SUCCESS,
 } from "../actions/channelMap";
+import {
+  ReleasesAction,
+  ReleasesReduxState,
+} from "../../../types/releaseTypes";
+
+type ChannelMapAction = ReleasesAction &
+  (
+    | {
+        type: typeof INIT_CHANNEL_MAP;
+        payload: { channelMap: ReleasesReduxState["channelMap"] };
+      }
+    | {
+        type: typeof SELECT_REVISION;
+        payload: {
+          revision: ReleasesReduxState["revisions"][string];
+          toggle: boolean;
+        };
+      }
+    | {
+        type: typeof CLEAR_SELECTED_REVISIONS;
+        payload: never;
+      }
+    | {
+        type: typeof RELEASE_REVISION_SUCCESS;
+        payload: {
+          revision: ReleasesReduxState["revisions"][string];
+          channel: string;
+        };
+      }
+    | {
+        type: typeof CLOSE_CHANNEL_SUCCESS;
+        payload: {
+          channel: string;
+        };
+      }
+  );
 
-function selectRevision(state, revision, toggle) {
+function selectRevision(
+  state: ReleasesReduxState["channelMap"],
+  revision: ReleasesReduxState["revisions"][string],
+  toggle: boolean
+) {
   const arch = revision.architectures[0];
 
   state = {
@@ -28,7 +68,11 @@ function selectRevision(state, revision, toggle) {
   return state;
 }
 
-function releaseRevision(state, revision, channel) {
+function releaseRevision(
+  state: ReleasesReduxState["channelMap"],
+  revision: ReleasesReduxState["revisions"][string],
+  channel: string
+) {
   state = {
     ...state,
     [channel]: { ...state[channel] },
@@ -49,7 +93,10 @@ function releaseRevision(state, revision, channel) {
   return state;
 }
 
-function closeChannel(state, channel) {
+function closeChannel(
+  state: ReleasesReduxState["channelMap"],
+  channel: string
+) {
   // if channel is already closed do nothing
   if (!state[channel]) {
     return state;
@@ -63,7 +110,10 @@ function closeChannel(state, channel) {
 
 // contains channel map for each channel in current track
 // also includes 'unassigned' fake channel to show selected unassigned revision
-export default function channelMap(state = {}, action) {
+export default function channelMap(
+  state: ReleasesReduxState["channelMap"] = {},
+  action: ChannelMapAction
+) {
   switch (action.type) {
     case INIT_CHANNEL_MAP:
       return {
@@ -73,7 +123,7 @@ export default function channelMap(state = {}, action) {
       return selectRevision(
         state,
         action.payload.revision,
-        action.payload.toggle,
+        action.payload.toggle
       );
     case CLEAR_SELECTED_REVISIONS:
       return {
@@ -84,7 +134,7 @@ export default function channelMap(state = {}, action) {
       return releaseRevision(
         state,
         action.payload.revision,
-        action.payload.channel,
+        action.payload.channel
       );
     case CLOSE_CHANNEL_SUCCESS:
       return closeChannel(state, action.payload.channel);

…sher/pages/Releases/reducers/branches.js …sher/pages/Releases/reducers/branches.tsstatic/js/publisher/pages/Releases/reducers/branches.js renamed to static/js/publisher/pages/Releases/reducers/branches.ts static/js/publisher/pages/Releases/reducers/branches.js renamed to static/js/publisher/pages/Releases/reducers/branches.ts

@@ -0,0 +1,23 @@
+import {
+  ReleasesAction,
+  ReleasesReduxState,
+} from "../../../types/releaseTypes";
+import { SET_CURRENT_TRACK } from "../actions/currentTrack";
+
+type CurrentTrackAction = ReleasesAction & {
+  payload: {
+    track: ReleasesReduxState["currentTrack"];
+  };
+};
+
+export default function currentTrack(
+  state: ReleasesReduxState["currentTrack"] = "",
+  action: CurrentTrackAction
+) {
+  switch (action.type) {
+    case SET_CURRENT_TRACK:
+      return action.payload.track;
+    default:
+      return state;
+  }
+}

…er/pages/Releases/reducers/channelMap.js …er/pages/Releases/reducers/channelMap.tsstatic/js/publisher/pages/Releases/reducers/channelMap.js renamed to static/js/publisher/pages/Releases/reducers/channelMap.ts static/js/publisher/pages/Releases/reducers/channelMap.js renamed to static/js/publisher/pages/Releases/reducers/channelMap.ts

@@ -0,0 +1,21 @@
+import {
+  ReleasesAction,
+  ReleasesReduxState,
+} from "../../../types/releaseTypes";
+import { SET_DEFAULT_TRACK_SUCCESS } from "../actions/defaultTrack";
+
+type DefaultTrackAction = ReleasesAction & {
+  payload: ReleasesReduxState["defaultTrack"];
+};
+
+export default function defaultTrack(
+  state: ReleasesReduxState["defaultTrack"] = "latest",
+  action: DefaultTrackAction
+) {
+  switch (action.type) {
+    case SET_DEFAULT_TRACK_SUCCESS:
+      return action.payload;
+    default:
+      return state;
+  }
+}