fix: changes based on PR feedback

Author: gajeshbhat

static/sass/styles.scss

@@ -277,7 +277,6 @@ dl {
   }
 }
 
-
 .snap-published-in-cell {
   @media (max-width: $breakpoint-large - 1) {
     display: none !important;

templates/store/snap-details/_details.html

@@ -16,18 +16,16 @@ <h3 class="p-muted-heading">Last updated</h3>
       <li>{{ updates[1]["released-at-display"] }} - <small>{{ updates[1]["track"] }}/{{ updates[1]["risk"] }}</small></li>
     {% endif %}
   </ul>
-  <hr class="p-rule--muted">
-{% endif %}
-
-{% if old_snap_info and old_snap_info.is_old %}
+  {% if old_snap_info and old_snap_info.is_old %}
   <div class="p-notification--caution is-borderless">
     <div class="p-notification__content">
       <p class="p-notification__message">
-        This snap in this channel hasn't been updated since {{ old_snap_info.last_updated_formatted }}. Contact the developer to ask for an update.
+        This snap hasn't been updated since {{ old_snap_info.last_updated_formatted }}. It might be unmaintained and have stability or security issues.
       </p>
     </div>
   </div>
-  <hr>
+  {% endif %}
+  <hr class="p-rule--muted">
 {% endif %}
 
 {% if links %}

webapp/store/logic.py

@@ -5,6 +5,7 @@
 
 import humanize
 from dateutil import parser
+from dateutil.relativedelta import relativedelta
 from webapp import helpers
 
 
@@ -245,11 +246,10 @@ def is_snap_old(last_updated_date, old_threshold_years=2.0):
 
         now = datetime.datetime.now(datetime.timezone.utc)
 
-        days_diff = (now - date_parsed).days
-        years_diff = days_diff / 365.25  # Account for leap years
-        years_since_update = int(years_diff)
+        delta = relativedelta(now, date_parsed)
+        years_since_update = delta.years
 
-        is_old = days_diff >= (old_threshold_years * 365.25)
+        is_old = years_since_update >= old_threshold_years
 
         return {
             "is_old": is_old,

webapp/store/snap_details_views.py

@@ -106,6 +106,24 @@ def _get_context_snap_details(snap_name, supported_architectures=None):
             lowest_risk_available,
             supported_architectures,
         )
+
+        # Determine the most recent update date from updates tuple
+        # updates[0] is the stable channel, updates[1] is the most
+        # recent non-stable
+        most_recent_update = None
+        if updates[0] and updates[1]:
+            # Compare both and use the most recent
+            date_0 = updates[0].get("released-at")
+            date_1 = updates[1].get("released-at")
+            if date_0 and date_1:
+                most_recent_update = max(date_0, date_1)
+            else:
+                most_recent_update = date_0 or date_1
+        elif updates[0]:
+            most_recent_update = updates[0].get("released-at")
+        elif updates[1]:
+            most_recent_update = updates[1].get("released-at")
+
         binary_filesize = latest_channel["download"]["size"]
 
         # filter out banner and banner-icon images from screenshots
@@ -191,7 +209,7 @@ def _get_context_snap_details(snap_name, supported_architectures=None):
             "filesize": humanize.naturalsize(binary_filesize),
             "last_updated": logic.convert_date(last_updated),
             "last_updated_raw": last_updated,
-            "old_snap_info": logic.is_snap_old(last_updated),
+            "old_snap_info": logic.is_snap_old(most_recent_update),
             "is_users_snap": is_users_snap,
             "unlisted": details.get("snap", {}).get("unlisted", False),
             "developer": developer,