fix: Address publisher metrics compiler warnings from TiCS (#5086)

Author: steverydz

static/js/public/snap-details/map.ts

@@ -7,17 +7,11 @@ import { feature, mesh } from "topojson-client";
 import { GeoJsonProperties } from "geojson";
 import { Topology, Objects } from "topojson-specification";
 
+import type { TerritoriesMetricsData } from "../../publisher/types/shared";
+
 export default function renderMap(
   el: string,
-  snapData: {
-    [key: number]: {
-      code: string;
-      color_rgb: number[];
-      name: string;
-      number_of_users: number;
-      percentage_of_users: number;
-    };
-  },
+  snapData: TerritoriesMetricsData,
 ) {
   const mapEl = select(el);
 
@@ -30,15 +24,7 @@ export default function renderMap(
 
   function render(
     mapEl: Selection<BaseType, unknown, HTMLElement, unknown>,
-    snapData: {
-      [key: number]: {
-        code: string;
-        color_rgb: number[];
-        name: string;
-        number_of_users: number;
-        percentage_of_users: number;
-      };
-    },
+    snapData: TerritoriesMetricsData,
     world: Topology<Objects<GeoJsonProperties>>,
   ) {
     const width = mapEl.property("clientWidth");

static/js/publisher/pages/Metrics/TerritoryMetrics.tsx

@@ -5,6 +5,8 @@ import { useEffect } from "react";
 import { renderTerritoriesMetrics } from "./metrics/metrics";
 import useCountryMetrics from "../../hooks/useCountryMetrics";
 
+import type { TerritoriesMetricsData } from "../../types/shared";
+
 export const TerritoryMetrics = ({
   isEmpty,
   onDataLoad,
@@ -21,15 +23,7 @@ export const TerritoryMetrics = ({
     status: string;
     data:
       | {
-          active_devices: {
-            [key: string]: {
-              code: string;
-              color_rgb: string;
-              name: string;
-              number_of_users: number;
-              percentage_of_users: number;
-            };
-          };
+          active_devices: TerritoriesMetricsData;
           territories_total: number;
         }
       | undefined;

…ublisher/pages/Metrics/metrics/config.js …ublisher/pages/Metrics/metrics/config.tsstatic/js/publisher/pages/Metrics/metrics/config.js renamed to static/js/publisher/pages/Metrics/metrics/config.ts static/js/publisher/pages/Metrics/metrics/config.js renamed to static/js/publisher/pages/Metrics/metrics/config.ts

@@ -8,7 +8,6 @@ import {
   prepareStackedData,
   prepareLineData,
   prepareScales,
-  prepareAnnotationsData,
   prepareAxis,
 } from "./dataProcessing";
 import {