Add tests for the helper function and the API endpoint

Author: bartaz

tests/publisher/cve/test_has_cve.py

@@ -0,0 +1,30 @@
+import unittest
+from unittest.mock import patch, MagicMock
+
+from webapp.publisher.cve.cve_helper import CveHelper
+from werkzeug.exceptions import NotFound
+
+
+class HasCvesTest(unittest.TestCase):
+
+    def setUp(self):
+        self.file_metadata = {"download_url": "https://example.com/file.json"}
+
+    @patch("requests.get")
+    def test_has_cve_data(self, mock_get):
+        mock_get.side_effect = [
+            MagicMock(status_code=200, json=lambda: self.file_metadata),
+        ]
+
+        result = CveHelper.has_cve_data("my-snap")
+
+        self.assertEqual(result, True)
+
+    @patch("requests.get")
+    def test_has_cve_data_not_found(self, mock_get):
+        mock_get.side_effect = [
+            MagicMock(status_code=404, json=lambda: {}),
+        ]
+
+        with self.assertRaises(NotFound):
+            CveHelper.has_cve_data("my-snap")

tests/publisher/cve/test_has_cve_api.py

@@ -0,0 +1,74 @@
+from unittest import TestCase
+from webapp.app import create_app
+from unittest.mock import patch
+
+
+class TestEndpoints(TestCase):
+    def setUp(self):
+        self.app = create_app(testing=True)
+        self.client = self.app.test_client()
+        self._log_in(is_canonical=False)
+
+    def _log_in(self, is_canonical=False):
+        test_macaroon = "test_macaroon"
+        with self.client.session_transaction() as s:
+            s["publisher"] = {
+                "account_id": "test_account_id",
+                "image": None,
+                "nickname": "XYZ",
+                "fullname": "ABC XYZ",
+                "email": "testing@testing.com",
+                "stores": [],
+                "is_canonical": is_canonical,
+            }
+            s["macaroons"] = test_macaroon
+            s["developer_token"] = test_macaroon
+            s["exchanged_developer_token"] = True
+
+    def _set_user_is_canonical(self, value):
+        self._log_in(is_canonical=value)
+
+
+class TestModelServiceEndpoints(TestEndpoints):
+    @patch(
+        "webapp.publisher.cve.cve_helper.CveHelper.has_cve_data",
+        return_value=True,
+    )
+    @patch(
+        "canonicalwebteam.store_api.dashboard.Dashboard.get_snap_info",
+        return_value={"snap_id": "id"},
+    )
+    def test_get_policies_for_canonical_user(
+        self, mock_get_snap_info, mock_get
+    ):
+        self._set_user_is_canonical(True)
+
+        response = self.client.get("api/snaps/cve/test")
+        data = response.json
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(data["success"], True)
+
+    @patch(
+        "webapp.publisher.cve.cve_helper.CveHelper.has_cve_data",
+        return_value=False,
+    )
+    @patch(
+        "canonicalwebteam.store_api.dashboard.Dashboard.get_snap_info",
+        return_value={"snap_id": "id"},
+    )
+    def test_get_policies_no_data(self, mock_get_snap_info, mock_get):
+        self._set_user_is_canonical(True)
+
+        response = self.client.get("api/snaps/cve/test")
+        data = response.json
+
+        self.assertEqual(response.status_code, 404)
+        self.assertEqual(data["success"], False)
+
+    def test_get_policies_for_non_canonical_user(self):
+        response = self.client.get("api/snaps/cve/test")
+        data = response.json
+
+        self.assertEqual(response.status_code, 403)
+        self.assertEqual(data["success"], False)

webapp/publisher/cve/cve_views.py

@@ -54,13 +54,12 @@ def has_cves(snap_name):
 
     snap_has_cves = CveHelper.has_cve_data(snap_name)
     if snap_has_cves:
-        return flask.jsonify({"success": True, "has_cves": True})
+        return flask.jsonify({"success": True})
     else:
         return (
             flask.jsonify(
                 {
-                    "success": True,
-                    "has_cves": False,
+                    "success": False,
                     "error": f"No CVEs data available for '{snap_name}' snap.",
                 }
             ),