TS types in redux actions and tests (#5535)

* TS types in redux actions and tests (#5529)

* Initial plan

* Convert 5 simple action files to TypeScript: globalNotification, modal, currentTrack, pendingCloses, revisions

Co-authored-by: edisile <4310497+edisile@users.noreply.github.com>

* Convert medium complexity action files to TypeScript: branches, architectures, availableRevisionsSelect, channelMap, history

Co-authored-by: edisile <4310497+edisile@users.noreply.github.com>

* Convert final complex action files to TypeScript: defaultTrack and pendingReleases

Co-authored-by: edisile <4310497+edisile@users.noreply.github.com>

* Fix test failure: remove extra properties from Progressive object

Co-authored-by: edisile <4310497+edisile@users.noreply.github.com>

* fix: available revisions action

* fix: release response types

* fix: types that copilot missed or mangled

* fix: tests imports, no idea how they passed before

* chore: cleanup unused imports

* chore: types for gaEventTracking action

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: edisile <4310497+edisile@users.noreply.github.com>

* fix: copilot suggestions

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

Author: edisile

static/js/publisher/pages/Releases/actions/architectures.js

@@ -0,0 +1,36 @@
+import {
+  GenericReleasesAction,
+  ReleasesReduxState,
+  Revision,
+} from "../../../types/releaseTypes";
+
+export const UPDATE_ARCHITECTURES = "UPDATE_ARCHITECTURES";
+
+export type UpdateArchitecturesAction = GenericReleasesAction<
+  typeof UPDATE_ARCHITECTURES,
+  {
+    architectures: ReleasesReduxState["architectures"];
+  }
+>;
+
+export type ArchitecturesAction = UpdateArchitecturesAction;
+
+export function updateArchitectures(
+  revisions: Revision[]
+): UpdateArchitecturesAction {
+  let archs: string[] = [];
+
+  revisions.forEach((revision) => {
+    archs = archs.concat(revision.architectures);
+  });
+
+  // make archs unique and sorted
+  archs = archs.filter((item, i, ar) => ar.indexOf(item) === i);
+
+  return {
+    type: UPDATE_ARCHITECTURES,
+    payload: {
+      architectures: archs,
+    },
+  };
+}

static/js/publisher/pages/Releases/actions/architectures.ts

@@ -10,26 +10,44 @@ import {
   getFilteredAvailableRevisionsForArch,
 } from "../selectors";
 import { getBuildId } from "../helpers";
+import {
+  GenericReleasesAction,
+  DispatchFn,
+  ReleasesReduxState,
+  Revision,
+  AvailableRevisionsSelect,
+} from "../../../types/releaseTypes";
 
 export const SET_AVAILABLE_REVISIONS_SELECT = "SET_AVAILABLE_REVISIONS_SELECT";
 
-export function setAvailableRevisionsSelect(value) {
+export type SetAvailableRevisionsSelectAction = GenericReleasesAction<
+  typeof SET_AVAILABLE_REVISIONS_SELECT,
+  {
+    value: AvailableRevisionsSelect;
+  }
+>;
+
+export type AvailableRevisionsSelectAction = SetAvailableRevisionsSelectAction;
+
+export function setAvailableRevisionsSelect(
+  value: AvailableRevisionsSelect
+): SetAvailableRevisionsSelectAction {
   return {
     type: SET_AVAILABLE_REVISIONS_SELECT,
     payload: { value },
   };
 }
 
-export function selectAvailableRevisions(value) {
-  return (dispatch, getState) => {
+export function selectAvailableRevisions(value: AvailableRevisionsSelect) {
+  return (dispatch: DispatchFn, getState: () => ReleasesReduxState) => {
     dispatch(setAvailableRevisionsSelect(value));
     dispatch(clearSelectedRevisions());
 
     const state = getState();
 
     // for each architecture
     const archs = getArchitectures(state);
-    let revisionsFilter = () => true;
+    let revisionsFilter: (revision: Revision) => boolean = () => true;
 
     // for Recent select only revisions from most recent uploaded version
     if (

…ases/actions/availableRevisionsSelect.js …ases/actions/availableRevisionsSelect.tsstatic/js/publisher/pages/Releases/actions/availableRevisionsSelect.js renamed to static/js/publisher/pages/Releases/actions/availableRevisionsSelect.ts static/js/publisher/pages/Releases/actions/availableRevisionsSelect.js renamed to static/js/publisher/pages/Releases/actions/availableRevisionsSelect.ts

@@ -0,0 +1,36 @@
+import { GenericReleasesAction, DispatchFn, ReleasesReduxState } from "../../../types/releaseTypes";
+
+export const OPEN_BRANCHES = "OPEN_BRANCHES";
+export const CLOSE_BRANCHES = "CLOSE_BRANCHES";
+
+export type OpenBranchesAction = GenericReleasesAction<typeof OPEN_BRANCHES, string>;
+
+export type CloseBranchesAction = GenericReleasesAction<typeof CLOSE_BRANCHES, string>;
+
+export type BranchesAction = OpenBranchesAction | CloseBranchesAction;
+
+export function openBranches(channelName: string): OpenBranchesAction {
+  return {
+    type: OPEN_BRANCHES,
+    payload: channelName,
+  };
+}
+
+export function closeBranches(channelName: string): CloseBranchesAction {
+  return {
+    type: CLOSE_BRANCHES,
+    payload: channelName,
+  };
+}
+
+export function toggleBranches(channelName: string) {
+  return (dispatch: DispatchFn, getState: () => ReleasesReduxState) => {
+    const { branches } = getState();
+
+    if (branches.includes(channelName)) {
+      dispatch(closeBranches(channelName));
+    } else {
+      dispatch(openBranches(channelName));
+    }
+  };
+}

static/js/publisher/pages/Releases/actions/branches.js

@@ -0,0 +1,107 @@
+import {
+  GenericReleasesAction,
+  ReleasesReduxState,
+  Revision,
+} from "../../../types/releaseTypes";
+
+export const INIT_CHANNEL_MAP = "INIT_CHANNEL_MAP";
+export const SELECT_REVISION = "SELECT_REVISION";
+export const CLEAR_SELECTED_REVISIONS = "CLEAR_SELECTED_REVISIONS";
+export const RELEASE_REVISION_SUCCESS = "RELEASE_REVISION_SUCCESS";
+export const CLOSE_CHANNEL_SUCCESS = "CLOSE_CHANNEL_SUCCESS";
+
+export type InitChannelMapAction = GenericReleasesAction<
+  typeof INIT_CHANNEL_MAP,
+  { channelMap: ReleasesReduxState["channelMap"] }
+>;
+
+export type SelectRevisionAction = GenericReleasesAction<
+  typeof SELECT_REVISION,
+  {
+    revision: Revision;
+    toggle: boolean;
+  }
+>;
+
+export type ClearSelectedRevisionAction = GenericReleasesAction<
+  typeof CLEAR_SELECTED_REVISIONS,
+  never
+>;
+
+export type ReleaseRevisionSuccessAction = GenericReleasesAction<
+  typeof RELEASE_REVISION_SUCCESS,
+  {
+    revision: Revision;
+    channel: string;
+  }
+>;
+
+export type CloseChannelSuccessAction = GenericReleasesAction<
+  typeof CLOSE_CHANNEL_SUCCESS,
+  {
+    channel: string;
+  }
+>;
+
+export type ChannelMapAction =
+  | InitChannelMapAction
+  | SelectRevisionAction
+  | ClearSelectedRevisionAction
+  | ReleaseRevisionSuccessAction
+  | CloseChannelSuccessAction;
+
+export function initChannelMap(
+  channelMap: ReleasesReduxState["channelMap"]
+): InitChannelMapAction {
+  return {
+    type: INIT_CHANNEL_MAP,
+    payload: { channelMap },
+  };
+}
+
+export function selectRevision(revision: Revision): SelectRevisionAction {
+  return {
+    type: SELECT_REVISION,
+    payload: { revision, toggle: false },
+  };
+}
+
+export function toggleRevision(revision: Revision): SelectRevisionAction {
+  return {
+    type: SELECT_REVISION,
+    payload: { revision, toggle: true },
+  };
+}
+
+export function clearSelectedRevisions(): ClearSelectedRevisionAction {
+  return {
+    type: CLEAR_SELECTED_REVISIONS,
+  };
+}
+
+export function releaseRevisionSuccess(
+  revision: Revision,
+  channel: string
+): ReleaseRevisionSuccessAction {
+  return {
+    type: RELEASE_REVISION_SUCCESS,
+    payload: {
+      revision,
+      channel,
+    },
+  };
+}
+
+/**
+ * 
+ * @param channel Channel to close
+ * @returns Action to close channel
+ */
+export function closeChannelSuccess(channel: string): CloseChannelSuccessAction {
+  return {
+    type: CLOSE_CHANNEL_SUCCESS,
+    payload: {
+      channel,
+    },
+  };
+}

static/js/publisher/pages/Releases/actions/branches.ts

@@ -0,0 +1,24 @@
+import {
+  GenericReleasesAction,
+  ReleasesReduxState,
+} from "../../../types/releaseTypes";
+
+export const SET_CURRENT_TRACK = "SET_CURRENT_TRACK";
+
+export type SetCurrentTrackAction = GenericReleasesAction<
+  typeof SET_CURRENT_TRACK,
+  {
+    track: ReleasesReduxState["currentTrack"];
+  }
+>;
+
+export type CurrentTrackAction = SetCurrentTrackAction;
+
+export function setCurrentTrack(
+  track: ReleasesReduxState["currentTrack"]
+): SetCurrentTrackAction {
+  return {
+    type: SET_CURRENT_TRACK,
+    payload: { track },
+  };
+}