Rename function for better clarity

Author: bartaz

tests/publisher/cve/test_has_cve.py

@@ -15,7 +15,7 @@ def test_returns_revision_numbers(self, mock_get_metadata):
             {"name": "789.yaml"},
         ]
 
-        result = CveHelper.has_revisions_with_cves("my-snap")
+        result = CveHelper.get_revisions_with_cves("my-snap")
         self.assertEqual(result, [123, 456, 789])
 
     @patch("webapp.publisher.cve.cve_helper.CveHelper._get_cve_file_metadata")
@@ -28,7 +28,7 @@ def test_ignores_non_yaml_files(self, mock_get_metadata):
             {"name": "data.txt"},
         ]
 
-        result = CveHelper.has_revisions_with_cves("my-snap")
+        result = CveHelper.get_revisions_with_cves("my-snap")
         self.assertEqual(result, [123, 456])
 
     @patch("webapp.publisher.cve.cve_helper.CveHelper._get_cve_file_metadata")
@@ -38,12 +38,12 @@ def test_returns_empty_list_if_no_revision_files(self, mock_get_metadata):
             {"name": "notes.txt"},
         ]
 
-        result = CveHelper.has_revisions_with_cves("my-snap")
+        result = CveHelper.get_revisions_with_cves("my-snap")
         self.assertEqual(result, [])
 
     @patch("webapp.publisher.cve.cve_helper.CveHelper._get_cve_file_metadata")
     def test_returns_empty_list_on_not_found(self, mock_get_metadata):
         mock_get_metadata.side_effect = NotFound()
 
-        result = CveHelper.has_revisions_with_cves("my-snap")
+        result = CveHelper.get_revisions_with_cves("my-snap")
         self.assertEqual(result, [])

tests/publisher/cve/test_has_cve_api.py

@@ -31,7 +31,7 @@ def _set_user_is_canonical(self, value):
 
 class TestModelServiceEndpoints(TestEndpoints):
     @patch(
-        "webapp.publisher.cve.cve_helper.CveHelper.has_revisions_with_cves",
+        "webapp.publisher.cve.cve_helper.CveHelper.get_revisions_with_cves",
         return_value=[123, 321],
     )
     @patch(
@@ -48,7 +48,7 @@ def test_has_cves_for_canonical_user(self, mock_get_snap_info, mock_get):
         self.assertEqual(data["success"], True)
 
     @patch(
-        "webapp.publisher.cve.cve_helper.CveHelper.has_revisions_with_cves",
+        "webapp.publisher.cve.cve_helper.CveHelper.get_revisions_with_cves",
         return_value=[],
     )
     @patch(

webapp/publisher/cve/cve_helper.py

@@ -111,7 +111,7 @@ def _fetch_file_content(snap_name, revision, file_metadata):
             raise NotFound
 
     @staticmethod
-    def has_revisions_with_cves(snap_name):
+    def get_revisions_with_cves(snap_name):
         try:
             contents = CveHelper._get_cve_file_metadata(
                 f"snap-cves/{snap_name}"

webapp/publisher/cve/cve_views.py

@@ -52,7 +52,7 @@ def get_revisions_with_cves(snap_name):
             status_code,
         )
 
-    revisions_with_cves = CveHelper.has_revisions_with_cves(snap_name)
+    revisions_with_cves = CveHelper.get_revisions_with_cves(snap_name)
     if len(revisions_with_cves) > 0:
         return flask.jsonify(
             {"success": True, "revisions": revisions_with_cves}