filter, reject, detect, some, every with error#774
filter, reject, detect, some, every with error#774charlierudolph wants to merge 14 commits intocaolan:masterfrom charlierudolph:cr-withError
Conversation
|
Thanks for this. It's going to be on hold until we're putting together async 2.0, though. |
|
Sounds good. Let me know if this ever needs any updates |
charlierudolph
changed the title
|
Updated this to include detect and fixes to the README.md |
|
Definitely 👍 on this |
# Conflicts: # lib/async.js
# Conflicts: # test/test-async.js
# Conflicts: # lib/async.js # test/test-async.js
|
+1 |
|
👍 I want to get one more 1.4.3 release out before we start a 2.0 branch tho (cause itll be a pain to keep rebasing the two) |
|
Sorry, been too busy recently to have free cycles for async :( |
|
Why do you even need a 2.0 branch? As long as you are following semantic versioning whats wrong with introducing a breaking change? |
|
It's nicer for people downstream to release a batch of breaking changes all at once, rather than one at a time. It's less work for people to have to check for breaking changes in their code at fewer times throughout the year. |
# Conflicts: # README.md
|
Still definitely 👍 but we're in the process of moving into a modular setup for a major version bump (#996, https://github.com/caolan/async/tree/modularization). If you want to reopen against that branch we'll get it in quickly, otherwise we'll pull in when where ready to merge that branch with master |
|
Closed via #1028! |
5 participants
@aearly
fixes #118