during & doDuring with async test#800
Merged
aearly merged 4 commits intocaolan:masterfrom Jun 28, 2015
uzyn:during
Merged
Conversation
Collaborator
|
👍, since several people have asked for it. Also -- I wonder if the test should be passed a callback of the form |
Contributor
Author
|
Awesome. Let me update that and the documentation as well. |
Contributor
Author
|
Alright. Updated as suggested. Thanks @aearly |
aearly
added a commit
that referenced
this pull request
Jun 28, 2015
during & doDuring with async test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's basically
whilstanddoWhilstwith async truth test.Addresses #156 #602
Will add documentation if maintainer is okay with this PR.