Skip to content

fix: matching_func works with multiply match#172

Merged
leeqvip merged 2 commits intoapache:masterfrom
Zxilly:fix/issue171
Jun 30, 2021
Merged

fix: matching_func works with multiply match#172
leeqvip merged 2 commits intoapache:masterfrom
Zxilly:fix/issue171

Conversation

@Zxilly
Copy link
Copy Markdown
Contributor

@Zxilly Zxilly commented Jun 29, 2021

fix #171

Signed-off-by: Zxilly zhouxinyu1001@gmail.com

Closes #171

Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
Copy link
Copy Markdown
Contributor Author

Zxilly commented Jun 29, 2021

@techoner @hsluoyz @natbusa plz review

Closes #171

Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly Zxilly changed the title fix: matching_func works with multipie match fix: matching_func works with multiply match Jun 29, 2021
@natbusa
Copy link
Copy Markdown

natbusa commented Jun 30, 2021

Thanks @Zxilly . I have tested the fix branch (fix/issue171) locally: same as in 1.1.3 as expected.
It correctly scans all available g2 .csv rules for a match.
Committed test files & unittest are ok.

@leeqvip leeqvip merged commit bbe45ad into apache:master Jun 30, 2021
github-actions bot pushed a commit that referenced this pull request Jun 30, 2021
## [1.2.1](v1.2.0...v1.2.1) (2021-06-30)

### Bug Fixes

* matching_func works with multiply match ([#172](#172)) ([bbe45ad](bbe45ad))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Zxilly Zxilly deleted the fix/issue171 branch June 30, 2021 02:38
Chimou0 pushed a commit to Chimou0/pycasbin that referenced this pull request Jul 17, 2025
* fix: matching_func works with multipie match

Closes apache#171

Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>

* chore: typo

Closes apache#171

Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
Chimou0 pushed a commit to Chimou0/pycasbin that referenced this pull request Jul 17, 2025
## [1.2.1](apache/casbin-pycasbin@v1.2.0...v1.2.1) (2021-06-30)

### Bug Fixes

* matching_func works with multiply match ([apache#172](apache#172)) ([bbe45ad](apache@bbe45ad))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add_named_matching_func not fully functional in 1.2.0

3 participants