Skip to content

feat: fix integer priority sorting#327

Merged
hsluoyz merged 2 commits intoapache:masterfrom
nschwane:fix/priority_sorting
Oct 18, 2023
Merged

feat: fix integer priority sorting#327
hsluoyz merged 2 commits intoapache:masterfrom
nschwane:fix/priority_sorting

Conversation

@nschwane
Copy link
Copy Markdown
Contributor

@nschwane nschwane commented Oct 18, 2023

Fix for #326. Fixes policy sorting with priorities if priorities are numbers.

Fix: #326

@casbin-bot
Copy link
Copy Markdown

@Nekotoxin please review

@casbin-bot casbin-bot requested a review from Nekotoxin October 18, 2023 14:57
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 18, 2023

CLA assistant check
All committers have signed the CLA.

@hsluoyz hsluoyz changed the title fix: fix integer priority sorting feat: fix integer priority sorting Oct 18, 2023
@hsluoyz
Copy link
Copy Markdown
Member

hsluoyz commented Oct 18, 2023

@nschwane plz fix CI:

image

@nschwane nschwane force-pushed the fix/priority_sorting branch from dcf52a3 to 33a06fb Compare October 18, 2023 15:27
@nschwane
Copy link
Copy Markdown
Contributor Author

@nschwane plz fix CI:

image

Fixed

@hsluoyz hsluoyz merged commit d5cd58a into apache:master Oct 18, 2023
github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
# [1.32.0](v1.31.2...v1.32.0) (2023-10-18)

### Features

* fix integer priority sorting ([#327](#327)) ([d5cd58a](d5cd58a))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nschwane nschwane deleted the fix/priority_sorting branch October 18, 2023 18:14
Chimou0 pushed a commit to Chimou0/pycasbin that referenced this pull request Jul 17, 2025
* fix: fix integer priority sorting

* fix: fix formatting with black
Chimou0 pushed a commit to Chimou0/pycasbin that referenced this pull request Jul 17, 2025
# [1.32.0](apache/casbin-pycasbin@v1.31.2...v1.32.0) (2023-10-18)

### Features

* fix integer priority sorting ([apache#327](apache#327)) ([d5cd58a](apache@d5cd58a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Policies with explicit integer priorities are not sorted correctly

4 participants