Skip to content

Commit 016c3e3

Browse files
cb341claude
andcommitted
docs: address code review comments in base.html
- Add comment explaining " | " separator in page_title - Add comment explaining og_type heuristic (page.date = article) - Add TODO for og-image.png (social sharing preview image) - Add CSS comment explaining why main resets text-align to left Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 0981c81 commit 016c3e3

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

_layouts/base.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
{%- assign site_url = "https://cb341.dev" -%}
22
{%- assign default_title = "Dani Bengl - Full-Stack Developer" -%}
33
{%- assign default_description = "Full-stack software developer specializing in Ruby on Rails, web applications, and modern development practices. Portfolio, blog, and projects." -%}
4+
{%- comment -%} " | " separator: e.g. "About | Dani Bengl - Full-Stack Developer" {%- endcomment -%}
45
{%- assign page_title = page.title | append: " | " | append: default_title | default: default_title -%}
56
{%- assign page_description = page.description | default: default_description -%}
67
{%- assign current_url = site_url | append: page.url -%}
8+
{%- comment -%} og_type: posts have page.date set; everything else is a website {%- endcomment -%}
79
{%- if page.date -%}
810
{%- assign og_type = "article" -%}
911
{%- else -%}
@@ -26,6 +28,7 @@
2628
<meta property="og:image" content="{{ site_url }}/og-image.png" />
2729
<meta property="og:site_name" content="CB341.DEV" />
2830
<meta property="og:locale" content="en_US" />
31+
<!-- TODO: create og-image.png for social sharing previews -->
2932
<meta property="twitter:card" content="summary_large_image" />
3033
<meta property="twitter:url" content="{{ current_url }}" />
3134
<meta property="twitter:title" content="{{ page_title }}" />
@@ -64,6 +67,7 @@
6467
text-align: center;
6568
}
6669

70+
/* reset: body centers header/footer, main overrides back to left */
6771
main {
6872
text-align: left;
6973
}

0 commit comments

Comments
 (0)