Refactor unit tests in favor of fact service_provider

Author: dhoppe

spec/classes/jira_service_spec.rb

@@ -6,7 +6,7 @@
       on_supported_os.each do |os, facts|
         context "on #{os}" do
           let(:facts) do
-            facts.merge(os: { family: facts['osfamily'] })
+            facts
           end
           let(:params) do
             { javahome: '/opt/java' }
@@ -15,53 +15,46 @@
             'package { "jdk": }'
           end
 
-          if os == 'RedHat'
-            context 'default params' do
-              it { is_expected.to contain_service('jira') }
-              it { is_expected.to compile.with_all_deps }
-              it do
-                is_expected.to contain_file('/etc/init.d/jira').
-                  with_content(%r{Short-Description: Start up JIRA}).
-                  with_content(%r{lockfile=/var/lock/subsys/jira})
-              end
+          case facts[:os]['family']
+          when 'RedHat'
+            service_file_location = if facts['service_provider'] == 'systemd'
+                                      '/usr/lib/systemd/system/jira.service'
+                                    else
+                                      '/etc/init.d/jira'
+                                    end
+          when 'Debian'
+            service_file_location = '/lib/systemd/system/jira.service'
+          end
+
+          context 'with defaults for all parameters' do
+            it { is_expected.to compile.with_all_deps }
+
+            case facts['service_provider']
+            when 'systemd'
               it do
-                is_expected.not_to contain_file('/usr/lib/systemd/system/jira.service').
+                is_expected.to contain_file(service_file_location).
                   with_content(%r{Atlassian Systemd Jira Service})
               end
-              it { is_expected.not_to contain_exec('refresh_systemd') }
-            end
-          end
-          if os == 'Debian'
-            context 'lockfile on Debian' do
-              it { is_expected.to compile.with_all_deps }
+              it { is_expected.to contain_exec('refresh_systemd') }
+            when 'redhat'
               it do
-                is_expected.to contain_file('/etc/init.d/jira').
-                  with_content(%r{/var/lock/jira})
+                is_expected.to contain_file(service_file_location).
+                  with_content(%r{Short-Description: Start up JIRA}).
+                  with_content(%r{lockfile=/var/lock/subsys/jira})
               end
             end
-          end
-          if os =~ %r{ubuntu}
-            context 'default params' do
-              it { is_expected.to compile.with_all_deps }
-            end
-          end
-          if os =~ %r{ubuntu-16}
-            context 'default params' do
-              let(:facts) do
-                facts.merge(operatingsystem: 'Ubuntu', operatingsystemmajrelease: '16.04')
-              end
 
-              it { is_expected.to contain_file('/lib/systemd/system/jira.service') }
-            end
+            it { is_expected.to contain_service('jira') }
           end
-          context 'overwriting service_manage param' do
+
+          context 'with service_manage set to false' do
             let(:params) do
               super().merge(service_manage: false)
             end
 
             it { is_expected.not_to contain_service('jira') }
           end
-          context 'overwriting service params' do
+          context 'with service_ensure set to stopped' do
             let(:params) do
               super().merge(
                 service_ensure: 'stopped',
@@ -77,21 +70,6 @@
                                                           'subscribe' => 'Package[jdk]')
             end
           end
-          context 'RedHat/CentOS 7 systemd init script' do
-            let(:facts) do
-              {
-                osfamily: 'RedHat',
-                operatingsystemmajrelease: '7',
-                os: { family: 'RedHat' }
-              }
-            end
-
-            it do
-              is_expected.to contain_file('/usr/lib/systemd/system/jira.service').
-                with_content(%r{Atlassian Systemd Jira Service})
-            end
-            it { is_expected.to contain_exec('refresh_systemd') }
-          end
         end
       end
     end

spec/spec_helper.rb

@@ -8,6 +8,33 @@
 
 require 'voxpupuli/test/spec_helper'
 
+# Rough conversion of grepping in the puppet source:
+# grep defaultfor lib/puppet/provider/service/*.rb
+add_custom_fact(:service_provider, lambda do |_os, facts|
+  case facts[:os]['family'].downcase
+  when 'archlinux'
+    'systemd'
+  when 'darwin'
+    'launchd'
+  when 'debian'
+    'systemd'
+  when 'freebsd'
+    'freebsd'
+  when 'gentoo'
+    'openrc'
+  when 'openbsd'
+    'openbsd'
+  when 'redhat'
+    facts[:operatingsystemrelease].to_i >= 7 ? 'systemd' : 'redhat'
+  when 'suse'
+    facts[:operatingsystemmajrelease].to_i >= 12 ? 'systemd' : 'redhat'
+  when 'windows'
+    'windows'
+  else
+    'init'
+  end
+end)
+
 if File.exist?(File.join(__dir__, 'default_module_facts.yml'))
   facts = YAML.load(File.read(File.join(__dir__, 'default_module_facts.yml')))
   if facts