fix: handle non-deterministic async order and revert unnecessary changes

Author: henri-hulski

src/actions/runNpmScript.js

@@ -3,8 +3,7 @@ import { runAll } from '../helpers/runAll'
 export function runNpmScript(scriptNameTag, args = [], providedPackageNames) {
   return function runNpmScript({ config, npm, resolve }) {
     const scriptName = resolve.value(scriptNameTag)
-    const packages =
-      providedPackageNames || Object.keys(config.packagesPaths).sort()
+    const packages = providedPackageNames || Object.keys(config.packagesPaths)
 
     return runAll(
       packages.map((name) => npm.runScript(name, scriptName, args))

test/utils/testAction.js

@@ -3,6 +3,21 @@ import { options, runCommandMock } from 'test-utils'
 import { Cooker } from 'repo-cooker'
 import assert from 'test-utils/assert'
 
+function normalizeOutput(output) {
+  return Object.keys(output).reduce((acc, key) => {
+    const value = output[key]
+    // Sort commands array to handle non-deterministic async order
+    if (key === 'commands' && Array.isArray(value)) {
+      acc[key] = [...value].sort((a, b) =>
+        (a.options?.cwd || '').localeCompare(b.options?.cwd || '')
+      )
+    } else {
+      acc[key] = value
+    }
+    return acc
+  }, {})
+}
+
 export function testAction(
   action,
   input,
@@ -13,7 +28,7 @@ export function testAction(
 ) {
   const dryRun = runCommandMock()
   const fullOptions = Object.assign({}, options, { dryRun }, extraOptions)
-  const cooker = Cooker(['--no-parallel'], fullOptions)
+  const cooker = Cooker(fullOptions)
 
   cooker
     .run([
@@ -26,11 +41,13 @@ export function testAction(
       action,
       ({ props }) => {
         assert.deepEqual(
-          Object.keys(output).reduce((acc, key) => {
-            acc[key] = props[key]
-            return acc
-          }, {}),
-          output,
+          normalizeOutput(
+            Object.keys(output).reduce((acc, key) => {
+              acc[key] = props[key]
+              return acc
+            }, {})
+          ),
+          normalizeOutput(output),
           done
         )
       },