Merge pull request #16 from chatbotkit/next

Release go-sdk

Author: pdparchitect

agent/tools.go

@@ -12,7 +12,6 @@ import (
 	"os"
 	"os/exec"
 	"strings"
-	"syscall"
 	"time"
 )
 
@@ -357,14 +356,11 @@ func execCommandHandler(ctx context.Context, args map[string]interface{}) (inter
 
 	cmd := exec.CommandContext(ctx, "sh", "-c", command)
 
-	// Start the command in its own process group so that cancellation kills
-	// all child processes (e.g. sleep, long-running builds) - not just the
-	// top-level shell.
-	cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
-	cmd.Cancel = func() error {
-		// Send SIGKILL to the entire process group (negative PID).
-		return syscall.Kill(-cmd.Process.Pid, syscall.SIGKILL)
-	}
+	// Ensure cancellation kills all child processes (e.g. sleep, long-running
+	// builds), not just the top-level shell. The mechanism is platform
+	// specific (process groups + SIGKILL on Unix), so it lives in
+	// tools_unix.go / tools_windows.go.
+	configureCancellation(cmd)
 
 	var stdout, stderr bytes.Buffer
 	cmd.Stdout = &stdout

agent/tools_unix.go

@@ -0,0 +1,18 @@
+//go:build !windows
+
+package agent
+
+import (
+	"os/exec"
+	"syscall"
+)
+
+// configureCancellation starts the command in its own process group and, on
+// cancellation, sends SIGKILL to the entire group (negative PID) so that all
+// child processes are terminated - not just the top-level shell.
+func configureCancellation(cmd *exec.Cmd) {
+	cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
+	cmd.Cancel = func() error {
+		return syscall.Kill(-cmd.Process.Pid, syscall.SIGKILL)
+	}
+}

agent/tools_windows.go

@@ -0,0 +1,11 @@
+//go:build windows
+
+package agent
+
+import "os/exec"
+
+// configureCancellation is a no-op on Windows, which has no process-group /
+// SIGKILL semantics equivalent to the Unix implementation. Cancellation falls
+// back to the default exec.CommandContext behaviour (Process.Kill on the
+// top-level process).
+func configureCancellation(cmd *exec.Cmd) {}