eslint cleanup

Author: ddooley

.eslintrc.js

@@ -17,6 +17,8 @@ module.exports = {
     ecmaVersion: 'latest',
     sourceType: 'module',
   },
-  rules: {},
+  rules: {
+    'no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
+  },
   plugins: ['jest'],
 };

lib/AppContext.js

@@ -11,7 +11,6 @@ import { createDataHarmonizerContainer, createDataHarmonizerTab } from '../web';
 import { getExportFormats } from 'schemas';
 import { range as arrayRange } from 'lodash';
 import { deepMerge } from '../lib/utils/objects';
-import Validator from './Validator';
 import i18next from 'i18next';
 
 import {SchemaEditor} from './SchemaEditor';
@@ -38,7 +37,7 @@ export default class AppContext {
     console.log("this should only be done once")
     // THIS WAS $(document), but that was causing haywire issues with Handsontable!!!!
     // Each tab was requiring a double click to fully render its table!!!
-    $('#data-harmonizer-tabs').on('dhTabChange', (event, class_name) => {
+    $('#data-harmonizer-tabs').on('dhTabChange', () => {
       //if (this.getCurrentDataHarmonizer() !== class_name) {
         //this.tabChange(class_name);
       //}
@@ -309,7 +308,7 @@ export default class AppContext {
     // .inherits[enum1 name, enum2 name, ... , this enum], merging each in order
     // such that permissible value labels, descriptions and mappings can be
     // overwritten.  See https://linkml.io/linkml-model/latest/docs/inherits/ 
-    Object.entries(schema.enums || {}).forEach(([enum_name, enum_obj]) => {
+    Object.entries(schema.enums || {}).forEach(([, enum_obj]) => {
       if (enum_obj.inherits) {
         const values = {};
         enum_obj.inherits.forEach(inherit_enum_name => {
@@ -377,7 +376,6 @@ export default class AppContext {
           const dhId = `data-harmonizer-grid-${index}`;
           const tab_label = class_obj.title ? class_obj.title : class_name;
           const dhTab = createDataHarmonizerTab(dhId, tab_label, class_name, tooltip, index === 0);
-          const self = this;
 
           // Future: Change createDataHarmonizerTab() to return jquery dom element id?
           dhTab.addEventListener('click', (event) => { 
@@ -830,7 +828,6 @@ export default class AppContext {
    */
   stringifyNestedVocabulary(vocab_list) {
     let ret = [];
-    let stack = [];
     for (const pointer in vocab_list) {
       let choice = vocab_list[pointer];
       this.setExportField(choice, false); // Move elsewhere?
@@ -1112,14 +1109,14 @@ export default class AppContext {
     // First pass establishes basic attributes so 2nd pass references to 
     // .parent or .child don't matter, i.e. classes can be processed in
     // any order.
-    Object.entries(schema.classes).forEach(([class_name, class_obj]) => {
+    Object.entries(schema.classes).forEach(([class_name]) => {
       if (class_name != 'Container' && class_name != 'dh_interface') {
         relations[class_name] = {
           parent: {},
           child: {},
           dependent_slots: {},
           foreign_key_count: 0,
-          target_slots: {},            
+          target_slots: {},
           unique_key_slots: {}
         };
       }
@@ -1286,7 +1283,6 @@ export default class AppContext {
     let class_dependents = this.relations[class_name].dependents;
     for (let [dependent_name] of class_dependents.entries()) {
       this.setDHTabStatus(dependent_name);
-      const dh = this.dhs[dependent_name];
     };
   };
 
@@ -1441,7 +1437,7 @@ export default class AppContext {
    * @param {Object} changes dictionary pertaining to a particular dh row's slots.
    * @return {Object} this.dependent_rows updated table of given start_name class's foreign and other keys and their current and changed values
    */
-  crudGetDependentRows(start_name, skippable=false, changes = {}) {
+  crudGetDependentRows(start_name, _skippable=false, changes = {}) {
     // Changes only apply to start_name class; all dependents should "see" them
     // only via dependent_rows foreign key values.
     let [key_vals, fkey_vals, fkey_status] = 
@@ -1450,8 +1446,8 @@ export default class AppContext {
     // Changes may include any key slots (not just foreign keys), but other
     // slots are ignored.
     let changed_keys = Object.fromEntries(Object.entries(key_vals)
-      .filter(([slot_name, value]) => changes.hasOwnProperty(slot_name))
-      .map(([slot_name, value]) => ([slot_name, changes[slot_name].value]))
+      .filter(([slot_name]) => changes.hasOwnProperty(slot_name))
+      .map(([slot_name]) => ([slot_name, changes[slot_name].value]))
     );
 
     this.dependent_rows.set(start_name, {
@@ -1549,7 +1545,7 @@ export default class AppContext {
         // are included in the cascade report even when only the top-level
         // ancestor (e.g. Schema) is selected.
         let search_vals = Object.fromEntries(
-          Object.entries(fkey_vals).filter(([k, v]) => v !== null)
+          Object.entries(fkey_vals).filter(([, v]) => v !== null)
         );
         let rows = this.crudFindAllRowsByKeyVals(class_name, search_vals);
         if (rows.length) {
@@ -1594,7 +1590,7 @@ export default class AppContext {
    * @return {Object} changed_key_vals by slot_name of key values that are changing (and need to be updated)
    * @return {Boolean} key_status = integer
    */
-  crudGetDependentKeyVals(class_name, changes) { 
+  crudGetDependentKeyVals(class_name, _changes) {
     const class_dh = this.dhs[class_name];
     let fkey_vals = {};
     let key_vals = {};
@@ -1814,8 +1810,8 @@ export default class AppContext {
   // controlled by dependent CRUD create and update actions.
   crudMakeForeignKeysReadOnly(dh, class_name) {
     Object.entries(this.crudGetParents(class_name)).forEach(
-      ([parent_name, parent]) => {
-        Object.entries(parent).forEach(([slot_name, foreign_name]) => {
+      ([, parent]) => {
+        Object.entries(parent).forEach(([slot_name]) => {
             let col = dh.slot_name_to_column[slot_name];
             if (dh.slots[col].required) {
               dh.updateColumnSettings(col, { readOnly: true });
@@ -1848,7 +1844,7 @@ export default class AppContext {
     let changed = false;
     let complete = Object.entries(key_obj.unique_key_slots)
       // If every slot has a value, then the whole key is complete.
-      .every(([index, slot_name]) => {
+      .every(([, slot_name]) => {
         // Key has a changed value (incl. null?), so update it.
         if (slot_name in changes) {
           changed = true; // signals that a change has been made to key.

lib/DataHarmonizer.js

@@ -1,22 +1,13 @@
 import '@selectize/selectize';
 import Handsontable from 'handsontable';
-import SheetClip from 'sheetclip';
 import $ from 'jquery';
-
-import YAML from 'yaml';//#{ parse, stringify } from 'yaml'
-//import {strOptions} from 'yaml/types'
-//strOptions.fold.lineWidth = 0; // Prevents yaml long strings from wrapping.
-//strOptions.fold.defaultStringType = 'QUOTE_DOUBLE'
-//YAML.scalarOptions.str.defaultType = 'QUOTE_SINGLE'
-//scalarOptions.str.defaultType = 'QUOTE_SINGLE'
 import i18next from 'i18next';
 import { renderContent, urlToClickableAnchor } from './utils/content';
 import { isEmpty, rowIsEmpty, isEmptyUnitVal } from '../lib/utils/general';
 
 import {
   changeCase,
   formatMultivaluedValue,
-  JSON_SCHEMA_FORMAT,
   MULTIVALUED_DELIMITER,
   parseMultivaluedValue
 } from './utils/fields';
@@ -197,7 +188,7 @@ class DataHarmonizer {
     // This catches case where user dblclicks on column label, and just wants 
     // to see help info. Without this check, column is selected first, which
     // blows away row selection.
-    Handsontable.hooks.add('beforeOnCellMouseDown', function(event, coords, element) {
+    Handsontable.hooks.add('beforeOnCellMouseDown', function(event, coords) {
        // Check if a column header was clicked
       if (coords.row < 0 && event.srcElement.classList.contains('secondary-header-text')) {
         event.stopImmediatePropagation(); // Prevent default behavior and bubbling
@@ -291,7 +282,7 @@ class DataHarmonizer {
             },
             row_above: {
               name: 'Insert row above',
-              callback (action, selection, event) {
+              callback () {
                 // Ensuring that rows inserted into foreign-key dependent tables
                 // take in the appropriate focused foreign-key values on creation.
                 self.addRows('insert_row_above', 1, self.hot.getSelected()[0][0]);
@@ -383,14 +374,14 @@ class DataHarmonizer {
           }
         },
         // FIXING ISSUE WHERE HIGHLIGHTED FIELDS AREN'T IN GOOD SHAPE AFTER SORTING.
-        afterColumnSort: function (currentSortConfig, destinationSortConfigs) {
+        afterColumnSort: function () {
         //  if (self.schema.name === 'DH_LinkML' && self.template_name === 'Slot') {
         //    // Somehow on first call the this.context.dhs doesnt exist yet, so passing self.
         //    self.schemaSlotClassView(self); 
         //  }
         },
 
-        afterFilter: function (filters) {
+        afterFilter: function () {
           // column: 0, conditions: ('cancogen_covid-19', "eq", [], operation: "conjunction"
 
         },
@@ -667,7 +658,6 @@ class DataHarmonizer {
           // self.current_selection[0] === null || 
           // self.current_selection[1] === null || 
           const row_change = !(self.current_selection[0] === row);
-          const column_change = !(self.current_selection[1] === column);
           self.current_selection = [row, column, row2, column2];
           if (column < 0) column = 0;
           if (row < 0) row = 0;
@@ -752,7 +742,7 @@ class DataHarmonizer {
   // Handsontable search extension for future use (fixed their example). 
   // DH search defaults to any substring match (See hot_settings above).
   // Function below provides string exact match (incl. case sensitivity)
-  searchMatchCriteria (queryStr, value, metadata) {
+  searchMatchCriteria (queryStr, value) {
     return queryStr.toString() === value?.toString();
   }
 
@@ -817,7 +807,7 @@ class DataHarmonizer {
 
       if (class_name != dependent_name && dependent_rep.count) {
         let fkey_vals = Object.entries(dependent_rep.fkey_vals)
-        .filter(([x, y]) => y != null)
+        .filter(([, y]) => y != null)
         .join('\n      ')
         .replaceAll(',', ': ');
         change_message += `\n - ${dependent_rep.count} ${dependent_name} record(s) with key:\n      ${fkey_vals}`;
@@ -832,7 +822,7 @@ class DataHarmonizer {
     // UPDATED: using .unique_key_slots rather than .target_slots
     const class_relations = this.context.relations[class_name];
     for (const key in class_relations.unique_key_slots) { //, ...class_relations.target_slots]
-      for (const [row, change] of Object.entries(changes)) {
+      for (const [, change] of Object.entries(changes)) {
         //console.log("CHANGE",class_name, "change", change,"KEY", key, row)
         if (key in change) {
           return true;
@@ -1389,7 +1379,7 @@ class DataHarmonizer {
       // attribute name (usually plural) as spreadsheet tab name.
       const match = Object.entries(this.schema.classes['Container'].attributes)
         // cls_key = name = usually plural container attribute name
-        .find(([cls_key, { name, range }]) => range == this.template.name);
+        .find(([, { range }]) => range == this.template.name);
       if (match) {
         sheet_name = match[0];
       }
@@ -1645,7 +1635,7 @@ class DataHarmonizer {
               items: dh.getDataAtCell(row, col)?.split(MULTIVALUED_DELIMITER) || [],
 
               hideSelected: false,
-              onChange: function(value) {
+              onChange: function() {
                 this.focus(); // required for cursor
               },
               /*

lib/FieldMapper.js

@@ -57,10 +57,8 @@
 import $ from 'jquery'; 
 import {readBrowserDHSettings, saveBrowserDHSettings, clearDH} from './Toolbar';
 import YAML from 'yaml';
-import { updateSheetRange } from '../lib/utils/files';
 // dataObjectToArray no longer used (JSON rows pre-converted to arrays in openJSONDataFile)
 // import { dataObjectToArray } from '../lib/utils/fields';
-import { utils as XlsxUtils } from 'xlsx/xlsx.js';
 
 // A call like fm = new FieldMapper().bind(this), provides caller environment
 // variables
@@ -90,7 +88,7 @@ export class FieldMapper {
     dh_settings.schema ??= {};
     if (!(schema.name in dh_settings.schema))
       dh_settings.schema[schema.name] = {};
-    Object.entries(dh_settings.schema[schema.name]).forEach(([name, value]) => {
+    Object.entries(dh_settings.schema[schema.name]).forEach(([name]) => {
       const newOption = new Option(name, name);
       $('#field-mapping-select').append(newOption);
     });
@@ -114,11 +112,11 @@ export class FieldMapper {
      * - copy it to field-mapping-name
      * - implement it in combined drag & drop table list of data file fields.
      */
-    $('#field-mapping-select').off('change').on('change', function(e) {
+    $('#field-mapping-select').off('change').on('change', function() {
       const profile_name = $('#field-mapping-select').val();
       $('#field-mapping-delete-btn').prop('disabled', profile_name == '');
       if (profile_name.length > 0) {
-        const [dh_settings, profile] = self.getProfile(profile_name);
+        const [, profile] =self.getProfile(profile_name);
         self.renderFieldMappingProfile(profile_name, profile);
       }
     });
@@ -150,7 +148,7 @@ export class FieldMapper {
       $('#field-mapping-name').val(profile_name)
       if (profile_name) {
         self.updateProfileMapping(profile_name); // profile object updated in-situ.
-        const [dh_settings, profile] = self.getProfile(profile_name);
+        const [, profile] =self.getProfile(profile_name);
         self.renderFieldMappingProfile(profile_name, profile);
       }
       else {
@@ -194,7 +192,7 @@ export class FieldMapper {
       const map_obj = mappings?.tables[template_name];
 
       // Process each row of data
-      Object.entries(data_table).forEach(([row_ptr, row]) => {
+      Object.entries(data_table).forEach(([, row]) => {
         const new_row = [];
 
         // Make full dh row, and add as many exact matches from incomming data
@@ -211,7 +209,7 @@ export class FieldMapper {
           // Might not be any rules for a table that is missing some fields but
           // user has not supplied any mappings.
           // Overwrite any (empty) fields with user-defined column mapping.
-          Object.entries(map_obj?.map || {}).forEach(([ptr, mapping]) => {
+          Object.entries(map_obj?.map || {}).forEach(([, mapping]) => {
             const col_from = data_field_to_col[mapping.from];
             const col_to = dh.slot_name_to_column[mapping.to];
             new_row[col_to] = row[col_from];
@@ -307,7 +305,7 @@ export class FieldMapper {
     // Loop through each section
     let done_data_row = {};
     Object.entries(dh.sections)
-      .forEach(([i, section]) => {
+      .forEach(([, section]) => {
 
       // Adding template and section to make easier to search and replace content.
       html += `
@@ -321,7 +319,7 @@ export class FieldMapper {
       // Starting at -1 so the first pre-match check begins at data column 0.
       let last_shown_data_row = -1;
 
-      Object.entries(section.children).forEach(([section_slot_row, slot]) => {
+      Object.entries(section.children).forEach(([, slot]) => {
 
         if (slot_matches[slot_row] >= 0) {
           const data_row = slot_matches[slot_row];
@@ -495,7 +493,7 @@ export class FieldMapper {
       dh_settings.schema = {};
     if (!(schema.name in dh_settings.schema))
       dh_settings.schema[schema.name] = {};
-    Object.entries(dh_settings.schema[schema.name]).forEach(([name, value]) => {
+    Object.entries(dh_settings.schema[schema.name]).forEach(([name]) => {
       const newOption = new Option(name, name);
       $('#field-mapping-select').append(newOption);
     });
@@ -577,13 +575,13 @@ export class FieldMapper {
   // Apply a saved mapping profile to the current field-mapping display.
   // Uses data-slot-name and data-field-name attributes for reliable matching.
   applyFieldMapping(profile_name) {
-    const [dh_settings, profile] = this.getProfile(profile_name);
+    const [, profile] =this.getProfile(profile_name);
 
     Object.entries(profile.tables || {}).forEach(([table_name, table_obj]) => {
 
       // Doing table by table; otherwise identical field names in different
       // tables lead to garbled rule implementation.
-      Object.entries(table_obj?.map || {}).forEach(([index, mapping]) => {
+      Object.entries(table_obj?.map || {}).forEach(([, mapping]) => {
         // Find the unmatched slot TD by data-slot-name attribute.
         const schema_slot_td = $(
           `table#field-mapping-table tbody[data-table="${table_name}"] > tr.field-mismatch > td:first-child[data-slot-name="${mapping.to}"]`