fix: address CodeRabbit review findings

- compile_graph: clean stale reverse edges on re-registration
- master_server: re-lookup document after co_await to avoid dangling ref
- master_server: don't set Ready until worker pool starts successfully
- master_server: pass worker_memory_limit to pool options
- master_server: send DocumentUpdateParams on didChange
- stateful_worker: use std::string in LRU list to avoid dangling StringRef
- tests: filter publishDiagnostics by target URI to prevent false matches
- test_file_operation: clear diagnostics latch before triggering rebuild

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 16bit-ykiko

src/server/compile_graph.cpp

@@ -7,6 +7,16 @@ namespace clice {
 void CompileGraph::register_unit(std::uint32_t path_id, llvm::ArrayRef<std::uint32_t> deps) {
     auto& unit = units[path_id];
     unit.path_id = path_id;
+
+    // Remove this unit from old dependencies' dependents lists
+    for(auto old_dep: unit.dependencies) {
+        auto it = units.find(old_dep);
+        if(it != units.end()) {
+            auto& dep_list = it->second.dependents;
+            dep_list.erase(std::remove(dep_list.begin(), dep_list.end(), path_id), dep_list.end());
+        }
+    }
+
     unit.dependencies.assign(deps.begin(), deps.end());
     for(auto dep_id: deps) {
         units[dep_id].dependents.push_back(path_id);

src/server/master_server.cpp

@@ -95,23 +95,24 @@ et::task<> MasterServer::run_build_drain(std::uint32_t path_id, std::string uri)
         if(doc_it == documents.end())
             co_return;
 
-        auto& doc = doc_it->second;
-        doc.build_running = true;
-        doc.build_requested = false;
-        auto gen = doc.generation;
+        doc_it->second.build_running = true;
+        doc_it->second.build_requested = false;
+        auto gen = doc_it->second.generation;
 
         // Ensure PCM/PCH dependencies are ready
         auto deps_ok = co_await compile_graph.compile_deps(path_id, loop);
+
+        // Re-lookup after co_await (map may have changed)
+        doc_it = documents.find(path_id);
+        if(doc_it == documents.end())
+            co_return;
+
         if(!deps_ok) {
             LOG_WARN("Dependency compilation failed for {}, skipping build", uri);
             clear_diagnostics(uri);
-            doc_it = documents.find(path_id);
-            if(doc_it == documents.end())
-                co_return;
-            auto& doc_after_deps = doc_it->second;
-            if(!doc_after_deps.build_requested) {
-                doc_after_deps.build_running = false;
-                doc_after_deps.drain_scheduled = false;
+            if(!doc_it->second.build_requested) {
+                doc_it->second.build_running = false;
+                doc_it->second.drain_scheduled = false;
                 co_return;
             }
             continue;
@@ -120,8 +121,8 @@ et::task<> MasterServer::run_build_drain(std::uint32_t path_id, std::string uri)
         // Send compile request to stateful worker
         worker::CompileParams params;
         params.uri = uri;
-        params.version = doc.version;
-        params.text = doc.text;
+        params.version = doc_it->second.version;
+        params.text = doc_it->second.text;
         fill_compile_args(path_pool.resolve(path_id), params.directory, params.arguments);
 
         auto result = co_await pool.send_stateful<worker::CompileParams>(path_id, params);
@@ -428,8 +429,6 @@ void MasterServer::register_handlers() {
 
     // === initialized ===
     peer.on_notification([this](const protocol::InitializedParams& params) {
-        lifecycle = ServerLifecycle::Ready;
-
         // Load configuration from workspace
         config = CliceConfig::load_from_workspace(workspace_root);
 
@@ -444,10 +443,14 @@ void MasterServer::register_handlers() {
         pool_opts.self_path = self_path;
         pool_opts.stateful_count = config.stateful_worker_count;
         pool_opts.stateless_count = config.stateless_worker_count;
+        pool_opts.worker_memory_limit = config.worker_memory_limit;
         if(!pool.start(pool_opts)) {
             LOG_ERROR("Failed to start worker pool");
+            return;
         }
 
+        lifecycle = ServerLifecycle::Ready;
+
         // Load CDB and build include graph in background
         loop.schedule(load_workspace());
 
@@ -567,6 +570,13 @@ void MasterServer::register_handlers() {
 
         doc.generation++;
 
+        // Notify the owning stateful worker so it marks the document dirty
+        worker::DocumentUpdateParams update;
+        update.uri = params.text_document.uri;
+        update.version = doc.version;
+        update.text = doc.text;
+        pool.notify_stateful(path_id, update);
+
         // Reset idle timer on user activity
         reset_idle_timer();
 

src/server/stateful_worker.cpp

@@ -48,16 +48,16 @@ class StatefulWorker {
 
     llvm::StringMap<std::unique_ptr<DocumentEntry>> documents;
 
-    // LRU tracking
-    std::list<llvm::StringRef> lru;
-    llvm::StringMap<std::list<llvm::StringRef>::iterator> lru_index;
+    // LRU tracking — owns keys so they don't dangle after request handler returns
+    std::list<std::string> lru;
+    llvm::StringMap<std::list<std::string>::iterator> lru_index;
 
     void touch_lru(llvm::StringRef uri) {
         auto it = lru_index.find(uri);
         if(it != lru_index.end()) {
             lru.erase(it->second);
         }
-        lru.push_front(uri);
+        lru.emplace_front(uri.str());
         lru_index[uri] = lru.begin();
     }
 

tests/integration/test_file_operation.py

@@ -36,10 +36,12 @@ async def test_clang_tidy(client: LSPClient, test_data_dir):
 @pytest.mark.asyncio
 async def test_hover_save_close(client: LSPClient, test_data_dir):
     workspace = test_data_dir / "hello_world"
+    target_uri = (workspace / "main.cpp").as_uri()
     diagnostics_received = asyncio.Event()
 
     def on_diagnostics(params):
-        diagnostics_received.set()
+        if params.get("uri") == target_uri:
+            diagnostics_received.set()
 
     client.register_notification_handler(
         "textDocument/publishDiagnostics", on_diagnostics
@@ -51,12 +53,12 @@ def on_diagnostics(params):
     # Wait for initial compilation to finish
     await asyncio.wait_for(diagnostics_received.wait(), timeout=15.0)
 
+    diagnostics_received.clear()
     content = client.get_file("main.cpp").content + "\nint saved = 1;\n"
     await client.did_change("main.cpp", content)
     await client.did_save("main.cpp", include_text=True)
 
     # Wait for recompilation after change
-    diagnostics_received.clear()
     await asyncio.wait_for(diagnostics_received.wait(), timeout=15.0)
 
     hover = await client.hover("main.cpp", 2, 4)  # hover on 'main'

tests/integration/test_server.py

@@ -79,12 +79,14 @@ async def test_incremental_change(client: LSPClient, test_data_dir):
 async def test_diagnostics_received(client: LSPClient, test_data_dir):
     """Opening a file should produce diagnostics."""
     workspace = test_data_dir / "hello_world"
+    target_uri = (workspace / "main.cpp").as_uri()
     diagnostics_received = asyncio.Event()
     received_diagnostics = []
 
     def on_diagnostics(params):
-        received_diagnostics.append(params)
-        diagnostics_received.set()
+        if params.get("uri") == target_uri:
+            received_diagnostics.append(params)
+            diagnostics_received.set()
 
     client.register_notification_handler(
         "textDocument/publishDiagnostics", on_diagnostics
@@ -163,10 +165,12 @@ async def test_multiple_files(client: LSPClient, test_data_dir):
 
 async def _wait_for_compilation(client, workspace):
     """Helper: wait for diagnostics to confirm compilation finished."""
+    target_uri = (workspace / "main.cpp").as_uri()
     diagnostics_received = asyncio.Event()
 
     def on_diagnostics(params):
-        diagnostics_received.set()
+        if params.get("uri") == target_uri:
+            diagnostics_received.set()
 
     client.register_notification_handler(
         "textDocument/publishDiagnostics", on_diagnostics
@@ -387,10 +391,12 @@ async def test_hover_on_unknown_file(client: LSPClient, test_data_dir):
 async def test_all_features_after_compile_wait(client: LSPClient, test_data_dir):
     """After waiting for compilation, exercise all feature requests and verify responses."""
     workspace = test_data_dir / "hello_world"
+    target_uri = (workspace / "main.cpp").as_uri()
     diagnostics_received = asyncio.Event()
 
     def on_diagnostics(params):
-        diagnostics_received.set()
+        if params.get("uri") == target_uri:
+            diagnostics_received.set()
 
     client.register_notification_handler(
         "textDocument/publishDiagnostics", on_diagnostics