Skip to content

Commit dcc7bb1

Browse files
committed
Tighten kubeconfig integration assertions and namespace denial check.
Validate that -x sets both cluster entry names and context cluster reference, and ensure the cross-namespace consumer denial test verifies the forbidden error references the target namespace. Made-with: Cursor
1 parent a61551a commit dcc7bb1

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

tests/test_provider_kubeconfig.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,8 @@ def _assert_kubeconfig_valid(
173173
if expected_cluster_name:
174174
self.assertEqual(cfg.get("current-context"), expected_cluster_name)
175175
self.assertEqual(ctx_entry.get("name"), expected_cluster_name)
176+
self.assertEqual(cluster_entry.get("name"), expected_cluster_name)
177+
self.assertEqual(ctx.get("cluster"), expected_cluster_name)
176178
if expected_namespace:
177179
self.assertEqual(ctx.get("namespace"), expected_namespace)
178180

@@ -289,8 +291,7 @@ def test_flags_s_and_x_combined(self):
289291

290292
def test_consumer_cannot_create_pod_in_other_namespace(self):
291293
"""
292-
Consumer kubeconfig: verify create/delete in other namespaces is forbidden.
293-
Consumer RBAC should restrict operations; creating a pod in another ns should fail.
294+
Consumer kubeconfig: verify creating a pod in another namespace is forbidden.
294295
"""
295296
ns = "kubeplus-test-restrict-" + uuid.uuid4().hex[:8]
296297
other_ns = "kubeplus-test-other-" + uuid.uuid4().hex[:8]
@@ -320,6 +321,11 @@ def test_consumer_cannot_create_pod_in_other_namespace(self):
320321
"Consumer should not be able to create pod in other namespace; got out=%r err=%r"
321322
% (out, err),
322323
)
324+
self.assertIn(
325+
other_ns,
326+
err,
327+
"Expected denial to reference the target other namespace; got err=%r" % (err,),
328+
)
323329
finally:
324330
_run_command("kubectl delete namespace " + other_ns + self.kubeconfig_flag + " 2>/dev/null")
325331
self._delete_for_cleanup(ns, sa=consumer_sa)

0 commit comments

Comments
 (0)