Commit 033c4e2
Arjun Sreedharan
supply: remove pre-installing mercurial
* There's no documentation that suggests that while installing from
a remote url via a VCS like `hg`, the `mercurial` package should be
pre-installed. [Pip documentation](https://pip.pypa.io/en/latest/topics/vcs-support/) just states that it requires a working
executable to be available, which already exists on the stack.
```
‣ docker run --init -it cloudfoundry/cflinuxfs3 bash -c "hg --version"
Mercurial Distributed SCM (version 4.5.3)
```
* When `fixtures/mercurial` is built by this branch's buildpack,
we can see in the log python-hglib (which was the package referred to in
the testdata by hg clone url) is installed.
```
Successfully installed Flask-2.2.2 ... python-hglib-2.6.2+2.1e7a64588ab0 ...
```
* Git history suggests that pre-installing mercurial via `pip install
mercurial`
([link](https://github.com/cloudfoundry/python-buildpack/blob/v1.7.58/src/python/supply/supply.go#L201-L215))
came into this buildpack from the original heroku buildpack fork.
Heroku has since removed it. See
heroku/heroku-buildpack-python#1111
* This change does not address why running an app with `mercurial`
present in the `requirements.txt` fails with the error pointing to a
non-existent include path to `Python.h` even after include location is
set via CFLAGS in 028a7b6. See [CI
log](https://buildpacks.ci.cf-app.com/teams/main/pipelines/python-buildpack/jobs/specs-edge-integration-develop/builds/1054#L62d6d57b:516).
The timing of this failure appearing in CI suggests that it's related to
the package using the new setuptools version as a transitive dependency.
See #574 This has to be separately investigated.1 parent 4b06c2d commit 033c4e2
2 files changed
+0
-65
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | 131 | | |
137 | 132 | | |
138 | 133 | | |
| |||
197 | 192 | | |
198 | 193 | | |
199 | 194 | | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | 195 | | |
220 | 196 | | |
221 | 197 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
456 | 456 | | |
457 | 457 | | |
458 | 458 | | |
459 | | - | |
460 | | - | |
461 | | - | |
462 | | - | |
463 | | - | |
464 | | - | |
465 | | - | |
466 | | - | |
467 | | - | |
468 | | - | |
469 | | - | |
470 | | - | |
471 | | - | |
472 | | - | |
473 | | - | |
474 | | - | |
475 | | - | |
476 | | - | |
477 | | - | |
478 | | - | |
479 | | - | |
480 | | - | |
481 | | - | |
482 | | - | |
483 | | - | |
484 | | - | |
485 | | - | |
486 | | - | |
487 | | - | |
488 | | - | |
489 | | - | |
490 | | - | |
491 | | - | |
492 | | - | |
493 | | - | |
494 | | - | |
495 | | - | |
496 | | - | |
497 | | - | |
498 | | - | |
499 | | - | |
500 | 459 | | |
501 | 460 | | |
502 | 461 | | |
| |||
0 commit comments