Skip to content

Commit 88ffd72

Browse files
Update dependency eslint-plugin-unicorn to v47 (#487)
1 parent f81ee0c commit 88ffd72

4 files changed

Lines changed: 79 additions & 57 deletions

File tree

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
'@cloudfour/eslint-plugin': major
33
---
44

5-
Update `eslint-plugin-unicorn` to `v45`
5+
Update `eslint-plugin-unicorn` from `v43` to `v47`
66

77
**New Rules**
88

@@ -11,6 +11,7 @@ Update `eslint-plugin-unicorn` to `v45`
1111
- [`@cloudfour/unicorn/no-unnecessary-await`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v45.0.0/docs/rules/no-unnecessary-await.md)
1212
- [`@cloudfour/unicorn/prefer-set-size`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v45.0.0/docs/rules/prefer-set-size.md)
1313
- [`@cloudfour/unicorn/switch-case-braces`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v45.0.0/docs/rules/switch-case-braces.md)
14+
- [`@cloudfour/unicorn/prefer-blob-reading-methods`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v47.0.0/docs/rules/prefer-blob-reading-methods.md)
1415

1516
**Newly Enabled Rules**
1617

@@ -19,6 +20,8 @@ Update `eslint-plugin-unicorn` to `v45`
1920
- [`@cloudfour/unicorn/no-unnecessary-await`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v45.0.0/docs/rules/no-unnecessary-await.md)
2021
- [`@cloudfour/unicorn/prefer-set-size`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v45.0.0/docs/rules/prefer-set-size.md)
2122
- [`@cloudfour/unicorn/switch-case-braces`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v45.0.0/docs/rules/switch-case-braces.md)
23+
- [`@cloudfour/unicorn/prefer-blob-reading-methods`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v47.0.0/docs/rules/prefer-blob-reading-methods.md)
24+
- [`@cloudfour/unicorn/prefer-event-target`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v47.0.0/docs/rules/prefer-event-target.md)
2225

2326
**Newly Disabled Rules**
2427

package-lock.json

Lines changed: 61 additions & 55 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"eslint-plugin-jsdoc": "^39.0.0",
3838
"eslint-plugin-n": "^15.2.3",
3939
"eslint-plugin-promise": "^6.0.0",
40-
"eslint-plugin-unicorn": "^45.0.0"
40+
"eslint-plugin-unicorn": "^47.0.0"
4141
},
4242
"peerDependencies": {
4343
"eslint": "^8.0.0"

src/config.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,23 @@ module.exports.configs = {
190190
// There isn't a good reason to force use of Number.POSITIVE_INFINITY instead of Infinity
191191
{ checkInfinity: false },
192192
],
193+
// String#replaceAll doesn't quite have enough browser/node support to enable this rule by default.
194+
// TODO [2024-01-01] Reconsider browser/node support for those two methods
195+
'unicorn/prefer-string-replace-all': 'off',
196+
// String#at and Array#at don't quite have enough browser/node support to enable this rule by default.
197+
// TODO [2024-01-01] Reconsider browser/node support for those two methods
198+
'unicorn/prefer-at': 'off',
193199
// This rule suggests incorrect code with the destructured object is modified
194200
// That is a fairly common case, and it is too annoying to always disable the rule on each line
195201
'unicorn/consistent-destructuring': 'off',
196202

203+
// Allow _only_ TODO comments with expirations/conditions
204+
'no-warning-comments': 'off',
205+
'unicorn/expiring-todo-comments': [
206+
'error',
207+
{ allowWarningComments: false },
208+
],
209+
197210
// Disabling jsdoc rules that check the types themselves
198211
// If you want to have type checking on a project, use typescript instead
199212
'jsdoc/newline-after-description': 'off',

0 commit comments

Comments
 (0)